netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Danielle Ratson <danieller@mellanox.com>
To: netdev@vger.kernel.org
Cc: mkubecek@suse.cz, f.fainelli@gmail.com, kuba@kernel.org,
	andrew@lunn.ch, mlxsw@nvidia.com,
	Danielle Ratson <danieller@mellanox.com>
Subject: [PATCH ethtool 4/5] shell-completion: Add completion for lanes
Date: Wed,  6 Jan 2021 15:10:05 +0200	[thread overview]
Message-ID: <20210106131006.2110613-5-danieller@mellanox.com> (raw)
In-Reply-To: <20210106131006.2110613-1-danieller@mellanox.com>

Lanes was added as a new link mode setting in ethtool.

Support completion for lanes when setting parameters.

Signed-off-by: Danielle Ratson <danieller@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
 shell-completion/bash/ethtool | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/shell-completion/bash/ethtool b/shell-completion/bash/ethtool
index 5305559..4557341 100644
--- a/shell-completion/bash/ethtool
+++ b/shell-completion/bash/ethtool
@@ -97,6 +97,7 @@ _ethtool_change()
 		[speed]=notseen
 		[wol]=notseen
 		[xcvr]=notseen
+		[lanes]=notseen
 	)
 
 	local -A msgtypes=(
@@ -175,6 +176,9 @@ _ethtool_change()
 		xcvr)
 			COMPREPLY=( $( compgen -W 'internal external' -- "$cur" ) )
 			return ;;
+		lanes)
+			# Number
+			return ;;
 	esac
 
 	local -a comp_words=()
-- 
2.26.2


  parent reply	other threads:[~2021-01-06 13:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 13:10 [PATCH ethtool 0/5] Extend uAPI with lanes parameter Danielle Ratson
2021-01-06 13:10 ` [PATCH ethtool 1/5] ethtool: Extend ethtool link modes settings uAPI with lanes Danielle Ratson
2021-01-06 13:10 ` [PATCH ethtool 2/5] netlink: settings: Add netlink support for lanes parameter Danielle Ratson
2021-01-06 13:10 ` [PATCH ethtool 3/5] netlink: settings: Expose the number of lanes in use Danielle Ratson
2021-01-06 13:10 ` Danielle Ratson [this message]
2021-01-06 13:10 ` [PATCH ethtool 5/5] man: Add man page for setting lanes parameter Danielle Ratson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106131006.2110613-5-danieller@mellanox.com \
    --to=danieller@mellanox.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).