From: Bjorn Helgaas <helgaas@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] PCI: Disable parity checking if broken_parity is set
Date: Wed, 6 Jan 2021 13:22:33 -0600 [thread overview]
Message-ID: <20210106192233.GA1329080@bjorn-Precision-5520> (raw)
In-Reply-To: <d375987c-ea4f-dd98-4ef8-99b2fbfe7c33@gmail.com>
On Wed, Jan 06, 2021 at 06:50:22PM +0100, Heiner Kallweit wrote:
> If we know that a device has broken parity checking, then disable it.
> This avoids quirks like in r8169 where on the first parity error
> interrupt parity checking will be disabled if broken_parity_status
> is set. Make pci_quirk_broken_parity() public so that it can be used
> by platform code, e.g. for Thecus N2100.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
This series should all go together. Let me know if you want me to do
anything more (would require acks for arm and r8169, of course).
> ---
> drivers/pci/quirks.c | 17 +++++++++++------
> include/linux/pci.h | 2 ++
> 2 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 653660e3b..ab54e26b8 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -205,17 +205,22 @@ static void quirk_mmio_always_on(struct pci_dev *dev)
> DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_ANY_ID, PCI_ANY_ID,
> PCI_CLASS_BRIDGE_HOST, 8, quirk_mmio_always_on);
>
> +void pci_quirk_broken_parity(struct pci_dev *dev)
> +{
> + u16 cmd;
> +
> + dev->broken_parity_status = 1; /* This device gives false positives */
> + pci_read_config_word(dev, PCI_COMMAND, &cmd);
> + pci_write_config_word(dev, PCI_COMMAND, cmd & ~PCI_COMMAND_PARITY);
> +}
> +
> /*
> * The Mellanox Tavor device gives false positive parity errors. Mark this
> * device with a broken_parity_status to allow PCI scanning code to "skip"
> * this now blacklisted device.
> */
> -static void quirk_mellanox_tavor(struct pci_dev *dev)
> -{
> - dev->broken_parity_status = 1; /* This device gives false positives */
> -}
> -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR, quirk_mellanox_tavor);
> -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR_BRIDGE, quirk_mellanox_tavor);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR, pci_quirk_broken_parity);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR_BRIDGE, pci_quirk_broken_parity);
>
> /*
> * Deal with broken BIOSes that neglect to enable passive release,
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index b32126d26..161dcc474 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1916,6 +1916,8 @@ enum pci_fixup_pass {
> pci_fixup_suspend_late, /* pci_device_suspend_late() */
> };
>
> +void pci_quirk_broken_parity(struct pci_dev *dev);
> +
> #ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS
> #define __DECLARE_PCI_FIXUP_SECTION(sec, name, vendor, device, class, \
> class_shift, hook) \
> --
> 2.30.0
>
>
>
next prev parent reply other threads:[~2021-01-06 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 17:49 [PATCH v3 0/3] PCI: Disable parity checking if broken_parity is set Heiner Kallweit
2021-01-06 17:50 ` [PATCH v3 1/3] " Heiner Kallweit
2021-01-06 19:22 ` Bjorn Helgaas [this message]
2021-01-06 19:34 ` Heiner Kallweit
2021-01-13 20:52 ` Heiner Kallweit
2021-01-13 21:25 ` Bjorn Helgaas
2021-01-14 12:42 ` Lennert Buytenhek
2021-01-06 17:51 ` [PATCH v3 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk Heiner Kallweit
2021-01-06 17:52 ` [PATCH v3 3/3] r8169: simplify broken parity handling now that PCI core takes care Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106192233.GA1329080@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).