From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D9CFC433DB for ; Sun, 10 Jan 2021 02:02:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDCB222513 for ; Sun, 10 Jan 2021 02:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726249AbhAJCCE (ORCPT ); Sat, 9 Jan 2021 21:02:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:58090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbhAJCCD (ORCPT ); Sat, 9 Jan 2021 21:02:03 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C278B22513; Sun, 10 Jan 2021 02:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610244083; bh=iCmz5Oe0rjZ45FKKL2ANl11S+MFBXpHu01TgXCj41ZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M/5OX8KSYi9YoRzFxDwKq2WjP1zo87nqyPETFvqilgut7I+dt6IwUq5lEV+VcK1BR Xn4XZKuY7Hi29vfv8KLVAJ2VrbJ3qup0FfMisGm9hyqX3rhr4stP4GqfYOf5Bzkc1+ R2sBA9rqOIHRKKvu/6ScAtzcvBT01+AO9cvvoMSErNASjMkLajsqDwz2uOvKJmofhF FKVvkbkArd64RYtywIMmMST+KOs2v7tbjBg26E6jTNazhETj0mpozMZwLDcT2e+W3M 0m+7EtOClzDbNTdeHORgHs1re3JVUjGu7oZesXiaRwHmjieI1OmMiGpR42Ws+uDtRW E+j8cXJjDoOXQ== Date: Sat, 9 Jan 2021 18:01:21 -0800 From: Jakub Kicinski To: Vladimir Oltean Cc: netdev@vger.kernel.org, alexandre.belloni@bootlin.com, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, alexandru.marginean@nxp.com, claudiu.manoil@nxp.com, xiaoliang.yang_1@nxp.com, hongbo.wang@nxp.com, jiri@resnulli.us, idosch@idosch.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports Message-ID: <20210109180121.7b1ed217@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210108175950.484854-9-olteanv@gmail.com> References: <20210108175950.484854-1-olteanv@gmail.com> <20210108175950.484854-9-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 8 Jan 2021 19:59:48 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > Add devlink integration into the mscc_ocelot switchdev driver. Only the > probed interfaces are registered with devlink, because for convenience, > struct devlink_port was included into struct ocelot_port_private, which > is only initialized for the ports that are used. This sounds like something that DSA should have a general policy on. I actually feel like it was discussed in the past.. Do you know what other drivers do?