From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E137CC433DB for ; Sat, 9 Jan 2021 19:15:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FB65206E9 for ; Sat, 9 Jan 2021 19:15:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbhAITPc (ORCPT ); Sat, 9 Jan 2021 14:15:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:49504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbhAITPc (ORCPT ); Sat, 9 Jan 2021 14:15:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E59D1206E9; Sat, 9 Jan 2021 19:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610219691; bh=SmXXBg/PFAnVl4lD56Fg2Rze5qQDH/LIcfWit7B6gj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVjgQ/HmLei1LhTXGEgh0JNvoyCrACFM2Vc3OM+ABfDDK0XVb7vejOZ6hvNfZIBJn YddthS46XgKURJbWntrtivYOv0G3WP9FjjX0RABnP3Ag+ZUhEU+zLQZR1PzPJeta4E vzTs12y/igN2ZePwv7Hep4paZryhb9fMr+KfiMbV79e3CPSzUzXIPJ4tcHPnujREsQ 6qzxpoJT8bcvEkWT2/YnAL1xL2emvtRoCe600LcFcIB70K70YCmyk2988fOtcVs4Ke W3cR/O7/x7+6eAYQ3+uOkileupEECXmrMH9eLzXAmX8re4369xkd5w3tmQZDiJYd13 M4U0nq0RL/sSg== Received: by pali.im (Postfix) id CB2B277B; Sat, 9 Jan 2021 20:14:47 +0100 (CET) Date: Sat, 9 Jan 2021 20:14:47 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Russell King - ARM Linux admin Cc: Andrew Lunn , "David S. Miller" , Jakub Kicinski , Thomas Schreiber , Heiner Kallweit , Marek =?utf-8?B?QmVow7pu?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Message-ID: <20210109191447.hunwx4fc4d4lox5f@pali> References: <20201230154755.14746-1-pali@kernel.org> <20210106153749.6748-1-pali@kernel.org> <20210106153749.6748-3-pali@kernel.org> <20210109154601.GZ1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210109154601.GZ1551@shell.armlinux.org.uk> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Saturday 09 January 2021 15:46:01 Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote: > > On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Rohár wrote: > > > From: Russell King > > > > > > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both > > > SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits in their EEPROM. > > > > > > Such combination of bits is meaningless so assume that LOS signal is not > > > implemented. > > > > > > This patch fixes link carrier for GPON SFP module Ubiquiti U-Fiber Instant. > > > > > > Signed-off-by: Russell King > > > Signed-off-by: Pali Rohár > > > > Reviewed-by: Andrew Lunn > > I'd like to send this patch irrespective of discussion on the other > patches - I already have it committed in my repository with a different > description, but the patch content is the same. > > Are you happy if I transfer Andrew's r-b tag, and convert yours to an > acked-by before I send it? > > I'd also like to add a patch that allows 2.5G if no other modes are > found, but the bitrate specified by the module allows 2.5G speed - much > like we do for 1G speeds. Russell, should I send a new version of patch series without this patch?