[PATCH net 0/9] MAINTAINERS: remove inactive folks from networking

[PATCH net 0/9] MAINTAINERS: remove inactive folks from networking

[Jakub Kicinski]

Hi!

This series intends to remove some most evidently inactive maintainers.

To make maintainers' lives easier we're trying to nudge people
towards CCing all the relevant folks on patches, in an attempt
to improve review rate. We have a check in patchwork which validates
the CC list against get_maintainers.pl. It's a little awkward, however,
to force people to CC maintainers who we haven't seen on the mailing
list for years. This series removes from maintainers folks who didn't
provide any tag (incl. authoring a patch) in the last 5 years.
To ensure reasonable signal to noise ratio we only considered
MAINTAINERS entries which had more than 100 patches fall under
them in that time period.

All this is purely a process-greasing exercise, I hope nobody
sees this series as an affront. Most folks are moved to CREDITS,
a couple entries are simply removed. 

The following inactive maintainers are kept, because they indicated
the intention to come back in the near future:

 - Veaceslav Falico (bonding)
 - Christian Benvenuti (Cisco drivers)

Patches in this series contain report from a script which did
the analysis. Big thanks to Jonathan Corbet for help and writing
the script (although I feel like I used it differently than Jon
may have intended ;)). The output format is thus:

 Subsystem $name
  Changes $reviewed / $total ($percent%)           // how many changes to the subsystem had at least one ack/review
  Last activity: $date_of_most_recent_patch
  $maintainer/reviewer1:
    Author $last_commit_authored_by_the_person $how_many_in_5yrs
    Committer $last_committed $how_many
    Tags $last_tag_like_review_signoff_etc $how_many
  $maintainer/reviewer2:
    Author $last_commit_authored_by_the_person $how_many_in_5yrs
    Committer $last_committed $how_many
    Tags $last_tag_like_review_signoff_etc $how_many
  Top reviewers: // Top 3 reviewers (who are not listed in MAINTAINERS)
    [$count_of_reviews_and_acks]: $email
  INACTIVE MAINTAINER $name   // maintainer / reviewer who has done nothing in last 5yrs

Jakub Kicinski (9):
  MAINTAINERS: altx: move Jay Cliburn to CREDITS
  MAINTAINERS: net: move Alexey Kuznetsov to CREDITS
  MAINTAINERS: vrf: move Shrijeet to CREDITS
  MAINTAINERS: ena: remove Zorik Machulsky from reviewers
  MAINTAINERS: tls: move Aviad to CREDITS
  MAINTAINERS: mtk-eth: remove Felix
  MAINTAINERS: ipvs: move Wensong Zhang to CREDITS
  MAINTAINERS: dccp: move Gerrit Renker to CREDITS
  MAINTAINERS: skge/sky2: move Mirko Lindner to CREDITS

 CREDITS     | 28 ++++++++++++++++++++++++++++
 MAINTAINERS | 11 +----------
 2 files changed, 29 insertions(+), 10 deletions(-)

-- 
2.26.2

[PATCH net 1/9] MAINTAINERS: altx: move Jay Cliburn to CREDITS

[Jakub Kicinski]

Jay was not active in recent years and does not have plans
to return to work on ATLX drivers.

Subsystem ATLX ETHERNET DRIVERS
  Changes 20 / 116 (17%)
  Last activity: 2020-02-24
  Jay Cliburn <jcliburn@gmail.com>:
  Chris Snook <chris.snook@gmail.com>:
    Tags ea973742140b 2020-02-24 00:00:00 1
  Top reviewers:
    [4]: andrew@lunn.ch
    [2]: kuba@kernel.org
    [2]: o.rempel@pengutronix.de
  INACTIVE MAINTAINER Jay Cliburn <jcliburn@gmail.com>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Jay Cliburn <jcliburn@gmail.com>
CC: Chris Snook <chris.snook@gmail.com>
---
 CREDITS     | 4 ++++
 MAINTAINERS | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/CREDITS b/CREDITS
index 090ed4b004a5..59a704a45170 100644
--- a/CREDITS
+++ b/CREDITS
@@ -710,6 +710,10 @@ S: Las Cuevas 2385 - Bo Guemes
 S: Las Heras, Mendoza CP 5539
 S: Argentina
 
+N: Jay Cliburn
+E: jcliburn@gmail.com
+D: ATLX Ethernet drivers
+
 N: Steven P. Cole
 E: scole@lanl.gov
 E: elenstev@mesatop.com
diff --git a/MAINTAINERS b/MAINTAINERS
index b15514a770e3..57e17762d411 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2942,7 +2942,6 @@ S:	Maintained
 F:	drivers/hwmon/asus_atk0110.c
 
 ATLX ETHERNET DRIVERS
-M:	Jay Cliburn <jcliburn@gmail.com>
 M:	Chris Snook <chris.snook@gmail.com>
 L:	netdev@vger.kernel.org
 S:	Maintained
-- 
2.26.2

[PATCH net 2/9] MAINTAINERS: net: move Alexey Kuznetsov to CREDITS

[Jakub Kicinski]

Move Alexey to CREDITS.

I am probably not giving him enough justice with
the description line..

Subsystem NETWORKING [IPv4/IPv6]
  Changes 1535 / 5111 (30%)
  Last activity: 2020-12-10
  "David S. Miller" <davem@davemloft.net>:
    Author b7e4ba9a91df 2020-12-09 00:00:00 407
    Committer e0fecb289ad3 2020-12-10 00:00:00 3992
    Tags e0fecb289ad3 2020-12-10 00:00:00 3978
  Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>:
  Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>:
    Tags d5d8760b78d0 2016-06-16 00:00:00 8
  Top reviewers:
    [225]: edumazet@google.com
    [222]: dsahern@gmail.com
    [176]: ncardwell@google.com
  INACTIVE MAINTAINER Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
---
 CREDITS     | 4 ++++
 MAINTAINERS | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/CREDITS b/CREDITS
index 59a704a45170..3dceea737694 100644
--- a/CREDITS
+++ b/CREDITS
@@ -2142,6 +2142,10 @@ E: seasons@falcon.sch.bme.hu
 E: seasons@makosteszta.sote.hu
 D: Original author of software suspend
 
+N: Alexey Kuznetsov
+E: kuznet@ms2.inr.ac.ru
+D: Author and maintainer of large parts of the networking stack
+
 N: Jaroslav Kysela
 E: perex@perex.cz
 W: https://www.perex.cz
diff --git a/MAINTAINERS b/MAINTAINERS
index 57e17762d411..c6e7f6bf7f6d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12417,7 +12417,6 @@ F:	tools/testing/selftests/net/ipsec.c
 
 NETWORKING [IPv4/IPv6]
 M:	"David S. Miller" <davem@davemloft.net>
-M:	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
 M:	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
 L:	netdev@vger.kernel.org
 S:	Maintained
-- 
2.26.2

[PATCH net 3/9] MAINTAINERS: vrf: move Shrijeet to CREDITS

[Jakub Kicinski]

Shrijeet has moved on from VRF-related work.

Subsystem VRF
  Changes 30 / 120 (25%)
  Last activity: 2020-12-09
  David Ahern <dsahern@kernel.org>:
    Author 1b6687e31a2d 2020-07-23 00:00:00 1
    Tags 9125abe7b9cb 2020-12-09 00:00:00 4
  Shrijeet Mukherjee <shrijeet@gmail.com>:
  Top reviewers:
    [13]: dsahern@gmail.com
    [4]: dsa@cumulusnetworks.com
  INACTIVE MAINTAINER Shrijeet Mukherjee <shrijeet@gmail.com>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Shrijeet Mukherjee <shrijeet@gmail.com>
CC: David Ahern <dsahern@kernel.org>
---
 CREDITS     | 4 ++++
 MAINTAINERS | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/CREDITS b/CREDITS
index 3dceea737694..98e7485ec106 100644
--- a/CREDITS
+++ b/CREDITS
@@ -2704,6 +2704,10 @@ N: Wolfgang Muees
 E: wolfgang@iksw-muees.de
 D: Auerswald USB driver
 
+N: Shrijeet Mukherjee
+E: shrijeet@gmail.com
+D: Network routing domains (VRF).
+
 N: Paul Mundt
 E: paul.mundt@gmail.com
 D: SuperH maintainer
diff --git a/MAINTAINERS b/MAINTAINERS
index c6e7f6bf7f6d..a06faf9e2018 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19056,7 +19056,6 @@ K:	regulator_get_optional
 
 VRF
 M:	David Ahern <dsahern@kernel.org>
-M:	Shrijeet Mukherjee <shrijeet@gmail.com>
 L:	netdev@vger.kernel.org
 S:	Maintained
 F:	Documentation/networking/vrf.rst
-- 
2.26.2

[PATCH net 4/9] MAINTAINERS: ena: remove Zorik Machulsky from reviewers

[Jakub Kicinski]

While ENA has 3 reviewers and 2 maintainers, we mostly see review
tags and comments from the maintainers. While we very much appreciate
Zorik's invovment in the community let's trim the reviewer list
down to folks we've seen tags from.

Subsystem AMAZON ETHERNET DRIVERS
  Changes 13 / 269 (4%)
  Last activity: 2020-11-24
  Netanel Belgazal <netanel@amazon.com>:
    Author 24dee0c7478d 2019-12-10 00:00:00 43
    Tags 0e3a3f6dacf0 2020-07-21 00:00:00 47
  Arthur Kiyanovski <akiyano@amazon.com>:
    Author 0e3a3f6dacf0 2020-07-21 00:00:00 79
    Tags 09323b3bca95 2020-11-24 00:00:00 104
  Guy Tzalik <gtzalik@amazon.com>:
    Tags 713865da3c62 2020-09-10 00:00:00 3
  Saeed Bishara <saeedb@amazon.com>:
    Tags 470793a78ce3 2020-02-11 00:00:00 2
  Zorik Machulsky <zorik@amazon.com>:
  Top reviewers:
    [4]: sameehj@amazon.com
    [3]: snelson@pensando.io
    [3]: shayagr@amazon.com
  INACTIVE MAINTAINER Zorik Machulsky <zorik@amazon.com>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Netanel Belgazal <netanel@amazon.com>
CC: Arthur Kiyanovski <akiyano@amazon.com>
CC: Guy Tzalik <gtzalik@amazon.com>
CC: Saeed Bishara <saeedb@amazon.com>
CC: Zorik Machulsky <zorik@amazon.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index a06faf9e2018..64dd19dfc9c3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -820,7 +820,6 @@ M:	Netanel Belgazal <netanel@amazon.com>
 M:	Arthur Kiyanovski <akiyano@amazon.com>
 R:	Guy Tzalik <gtzalik@amazon.com>
 R:	Saeed Bishara <saeedb@amazon.com>
-R:	Zorik Machulsky <zorik@amazon.com>
 L:	netdev@vger.kernel.org
 S:	Supported
 F:	Documentation/networking/device_drivers/ethernet/amazon/ena.rst
-- 
2.26.2

[PATCH net 5/9] MAINTAINERS: tls: move Aviad to CREDITS

[Jakub Kicinski]

Aviad wrote parts of the initial TLS implementation
but hasn't been contributing to TLS since.

Subsystem NETWORKING [TLS]
  Changes 123 / 308 (39%)
  Last activity: 2020-12-01
  Boris Pismenny <borisp@nvidia.com>:
    Tags 138559b9f99d 2020-11-17 00:00:00 1
  Aviad Yehezkel <aviadye@nvidia.com>:
  John Fastabend <john.fastabend@gmail.com>:
    Author e91de6afa81c 2020-06-01 00:00:00 22
    Tags e91de6afa81c 2020-06-01 00:00:00 29
  Daniel Borkmann <daniel@iogearbox.net>:
    Author c16ee04c9b30 2018-10-20 00:00:00 7
    Committer b8e202d1d1d0 2020-02-21 00:00:00 19
    Tags b8e202d1d1d0 2020-02-21 00:00:00 28
  Jakub Kicinski <kuba@kernel.org>:
    Author 5c39f26e67c9 2020-11-27 00:00:00 89
    Committer d31c08007523 2020-12-01 00:00:00 15
    Tags d31c08007523 2020-12-01 00:00:00 117
  Top reviewers:
    [50]: dirk.vandermerwe@netronome.com
    [26]: simon.horman@netronome.com
    [14]: john.hurley@netronome.com
  INACTIVE MAINTAINER Aviad Yehezkel <aviadye@nvidia.com>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Aviad Yehezkel <aviadye@nvidia.com>
CC: Boris Pismenny <borisp@nvidia.com>
CC: John Fastabend <john.fastabend@gmail.com>
CC: Daniel Borkmann <daniel@iogearbox.net>
---
 CREDITS     | 4 ++++
 MAINTAINERS | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/CREDITS b/CREDITS
index 98e7485ec106..90384691876c 100644
--- a/CREDITS
+++ b/CREDITS
@@ -4122,6 +4122,10 @@ S: B-1206 Jingmao Guojigongyu
 S: 16 Baliqiao Nanjie, Beijing 101100
 S: People's Repulic of China
 
+N: Aviad Yehezkel
+E: aviadye@nvidia.com
+D: Kernel TLS implementation and offload support.
+
 N: Victor Yodaiken
 E: yodaiken@fsmlabs.com
 D: RTLinux (RealTime Linux)
diff --git a/MAINTAINERS b/MAINTAINERS
index 64dd19dfc9c3..92fdc134ca14 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12472,7 +12472,6 @@ F:	net/ipv6/tcp*.c
 
 NETWORKING [TLS]
 M:	Boris Pismenny <borisp@nvidia.com>
-M:	Aviad Yehezkel <aviadye@nvidia.com>
 M:	John Fastabend <john.fastabend@gmail.com>
 M:	Daniel Borkmann <daniel@iogearbox.net>
 M:	Jakub Kicinski <kuba@kernel.org>
-- 
2.26.2

[PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

[Jakub Kicinski]

Drop Felix from Mediatek Ethernet driver maintainers.
We haven't seen any tags since the initial submission.

Not adding a CREDITS entry because summarizing Felix's
contributions as "initial Mediatek MT7623 driver" is
really selling it short. And Felix is not gone, so he
can write his own description :P

Subsystem MEDIATEK ETHERNET DRIVER
  Changes 39 / 196 (19%)
  Last activity: 2020-04-07
  Felix Fietkau <nbd@nbd.name>:
  John Crispin <john@phrozen.org>:
    Author 6427dc1da51d 2017-08-09 00:00:00 28
    Tags 6427dc1da51d 2017-08-09 00:00:00 38
  Sean Wang <sean.wang@mediatek.com>:
    Author 880c2d4b2fdf 2019-06-03 00:00:00 50
    Tags a5d75538295b 2020-04-07 00:00:00 55
  Mark Lee <Mark-MC.Lee@mediatek.com>:
    Author 8d66a8183d0c 2019-11-14 00:00:00 4
    Tags 8d66a8183d0c 2019-11-14 00:00:00 4
  Top reviewers:
    [8]: andrew@lunn.ch
    [7]: f.fainelli@gmail.com
  INACTIVE MAINTAINER Felix Fietkau <nbd@nbd.name>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Felix Fietkau <nbd@nbd.name>
CC: John Crispin <john@phrozen.org>
CC: Sean Wang <sean.wang@mediatek.com>
CC: Mark Lee <Mark-MC.Lee@mediatek.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 92fdc134ca14..b3e88594808a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11165,7 +11165,6 @@ F:	Documentation/devicetree/bindings/dma/mtk-*
 F:	drivers/dma/mediatek/
 
 MEDIATEK ETHERNET DRIVER
-M:	Felix Fietkau <nbd@nbd.name>
 M:	John Crispin <john@phrozen.org>
 M:	Sean Wang <sean.wang@mediatek.com>
 M:	Mark Lee <Mark-MC.Lee@mediatek.com>
-- 
2.26.2

[PATCH net 7/9] MAINTAINERS: ipvs: move Wensong Zhang to CREDITS

[Jakub Kicinski]

Move Wensong Zhang to credits, we haven't heard from
him in years.

Subsystem IPVS
  Changes 83 / 226 (36%)
  Last activity: 2020-11-27
  Wensong Zhang <wensong@linux-vs.org>:
  Simon Horman <horms@verge.net.au>:
    Committer c24b75e0f923 2019-10-24 00:00:00 33
    Tags 7980d2eabde8 2020-10-12 00:00:00 76
  Julian Anastasov <ja@ssi.bg>:
    Author 7980d2eabde8 2020-10-12 00:00:00 26
    Tags 4bc3c8dc9f5f 2020-11-27 00:00:00 78
  Top reviewers:
    [6]: horms+renesas@verge.net.au
  INACTIVE MAINTAINER Wensong Zhang <wensong@linux-vs.org>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Wensong Zhang <wensong@linux-vs.org>
CC: Simon Horman <horms@verge.net.au>
CC: Julian Anastasov <ja@ssi.bg>
---
 CREDITS     | 4 ++++
 MAINTAINERS | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/CREDITS b/CREDITS
index 90384691876c..ce8eae8c5aa4 100644
--- a/CREDITS
+++ b/CREDITS
@@ -4183,6 +4183,10 @@ S: 1507 145th Place SE #B5
 S: Bellevue, Washington 98007
 S: USA
 
+N: Wensong Zhang
+E: wensong@linux-vs.org
+D: IP virtual server (IPVS).
+
 N: Haojian Zhuang
 E: haojian.zhuang@gmail.com
 D: MMP support
diff --git a/MAINTAINERS b/MAINTAINERS
index b3e88594808a..a5d69857f85a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9325,7 +9325,6 @@ W:	http://www.adaptec.com/
 F:	drivers/scsi/ips*
 
 IPVS
-M:	Wensong Zhang <wensong@linux-vs.org>
 M:	Simon Horman <horms@verge.net.au>
 M:	Julian Anastasov <ja@ssi.bg>
 L:	netdev@vger.kernel.org
-- 
2.26.2

[PATCH net 8/9] MAINTAINERS: dccp: move Gerrit Renker to CREDITS

[Jakub Kicinski]

As far as I can tell we haven't heard from Gerrit for roughly
5 years now. DCCP patch would really benefit from some review.
Gerrit was the last maintainer so mark this entry as orphaned.

Subsystem DCCP PROTOCOL
  Changes 38 / 166 (22%)
  (No activity)
  Top reviewers:
    [6]: kstewart@linuxfoundation.org
    [6]: allison@lohutok.net
    [5]: edumazet@google.com
  INACTIVE MAINTAINER Gerrit Renker <gerrit@erg.abdn.ac.uk>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Gerrit Renker <gerrit@erg.abdn.ac.uk>
CC: dccp@vger.kernel.org
---
 CREDITS     | 4 ++++
 MAINTAINERS | 3 +--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/CREDITS b/CREDITS
index ce8eae8c5aa4..9add7e6a4fa0 100644
--- a/CREDITS
+++ b/CREDITS
@@ -1288,6 +1288,10 @@ D: Major kbuild rework during the 2.5 cycle
 D: ISDN Maintainer
 S: USA
 
+N: Gerrit Renker
+E: gerrit@erg.abdn.ac.uk
+D: DCCP protocol support.
+
 N: Philip Gladstone
 E: philip@gladstonefamily.net
 D: Kernel / timekeeping stuff
diff --git a/MAINTAINERS b/MAINTAINERS
index a5d69857f85a..17736ec96ec4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4920,9 +4920,8 @@ F:	Documentation/scsi/dc395x.rst
 F:	drivers/scsi/dc395x.*
 
 DCCP PROTOCOL
-M:	Gerrit Renker <gerrit@erg.abdn.ac.uk>
 L:	dccp@vger.kernel.org
-S:	Maintained
+S:	Orphan
 W:	http://www.linuxfoundation.org/collaborate/workgroups/networking/dccp
 F:	include/linux/dccp.h
 F:	include/linux/tfrc.h
-- 
2.26.2

[PATCH net 9/9] MAINTAINERS: skge/sky2: move Mirko Lindner to CREDITS

[Jakub Kicinski]

We haven't heard from Mirko in 6 years.

There are only 57 changes to this driver, but it seems
like a pretty clear cut case.

Subsystem MARVELL GIGABIT ETHERNET DRIVERS (skge/sky2)
  Changes 11 / 57 (19%)
  Last activity: 2020-11-11
  Mirko Lindner <mlindner@marvell.com>:
  Stephen Hemminger <stephen@networkplumber.org>:
    Author 5aafeb74b5bb 2019-09-24 00:00:00 5
    Tags 0575bedd6a15 2020-11-11 00:00:00 5
  Top reviewers:
    [2]: edumazet@google.com
    [1]: andrew@lunn.ch
  INACTIVE MAINTAINER Mirko Lindner <mlindner@marvell.com>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Mirko Lindner <mlindner@marvell.com>
CC: Stephen Hemminger <stephen@networkplumber.org>
---
 CREDITS     | 4 ++++
 MAINTAINERS | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/CREDITS b/CREDITS
index 9add7e6a4fa0..87699f2ee6ad 100644
--- a/CREDITS
+++ b/CREDITS
@@ -2262,6 +2262,10 @@ D: and much more. He was the maintainer of MD from 2016 to 2018. Shaohua
 D: passed away late 2018, he will be greatly missed.
 W: https://www.spinics.net/lists/raid/msg61993.html
 
+N: Mirko Lindner
+E: mlindner@marvell.com
+D: Marvell Gigabit Ethernet drivers (skge/sky2).
+
 N: Stephan Linz
 E: linz@mazet.de
 E: Stephan.Linz@gmx.de
diff --git a/MAINTAINERS b/MAINTAINERS
index 17736ec96ec4..1e0d1e1fcf46 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10604,7 +10604,6 @@ F:	drivers/crypto/marvell/
 F:	include/linux/soc/marvell/octeontx2/
 
 MARVELL GIGABIT ETHERNET DRIVERS (skge/sky2)
-M:	Mirko Lindner <mlindner@marvell.com>
 M:	Stephen Hemminger <stephen@networkplumber.org>
 L:	netdev@vger.kernel.org
 S:	Maintained
-- 
2.26.2

Re: [PATCH net 1/9] MAINTAINERS: altx: move Jay Cliburn to CREDITS

[Chris Snook]

On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Jay was not active in recent years and does not have plans
> to return to work on ATLX drivers.
>
> Subsystem ATLX ETHERNET DRIVERS
>   Changes 20 / 116 (17%)
>   Last activity: 2020-02-24
>   Jay Cliburn <jcliburn@gmail.com>:
>   Chris Snook <chris.snook@gmail.com>:
>     Tags ea973742140b 2020-02-24 00:00:00 1
>   Top reviewers:
>     [4]: andrew@lunn.ch
>     [2]: kuba@kernel.org
>     [2]: o.rempel@pengutronix.de
>   INACTIVE MAINTAINER Jay Cliburn <jcliburn@gmail.com>
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: Jay Cliburn <jcliburn@gmail.com>
> CC: Chris Snook <chris.snook@gmail.com>
> ---

I'm overdue to be moved to CREDITS as well. I never had alx hardware,
I no longer have atl1c or atl1e hardware, and I haven't powered on my
atl1 or atl2 hardware in years.

- Chris

>  CREDITS     | 4 ++++
>  MAINTAINERS | 1 -
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/CREDITS b/CREDITS
> index 090ed4b004a5..59a704a45170 100644
> --- a/CREDITS
> +++ b/CREDITS
> @@ -710,6 +710,10 @@ S: Las Cuevas 2385 - Bo Guemes
>  S: Las Heras, Mendoza CP 5539
>  S: Argentina
>
> +N: Jay Cliburn
> +E: jcliburn@gmail.com
> +D: ATLX Ethernet drivers
> +
>  N: Steven P. Cole
>  E: scole@lanl.gov
>  E: elenstev@mesatop.com
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b15514a770e3..57e17762d411 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2942,7 +2942,6 @@ S:        Maintained
>  F:     drivers/hwmon/asus_atk0110.c
>
>  ATLX ETHERNET DRIVERS
> -M:     Jay Cliburn <jcliburn@gmail.com>
>  M:     Chris Snook <chris.snook@gmail.com>
>  L:     netdev@vger.kernel.org
>  S:     Maintained
> --
> 2.26.2
>

Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

[Joe Perches]

On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote:
> Drop Felix from Mediatek Ethernet driver maintainers.
> We haven't seen any tags since the initial submission.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -11165,7 +11165,6 @@ F:	Documentation/devicetree/bindings/dma/mtk-*
>  F:	drivers/dma/mediatek/
>  
> 
>  MEDIATEK ETHERNET DRIVER
> -M:	Felix Fietkau <nbd@nbd.name>
>  M:	John Crispin <john@phrozen.org>
>  M:	Sean Wang <sean.wang@mediatek.com>
>  M:	Mark Lee <Mark-MC.Lee@mediatek.com>

I think your script is broken as there are multiple subdirectories
for this entry and Felix is active.

For instance:

commit 9716ef046b46a6426b2a11301ea5232fc8cdce63
Author: Felix Fietkau <nbd@nbd.name>
Date:   Sat Nov 21 18:23:35 2020 +0100

    mt76: attempt to free up more room when filling the tx queue
    
    Run dma cleanup immediately if the queue is almost full, instead of waiting
    for the tx interrupt
    
    Signed-off-by: Felix Fietkau <nbd@nbd.name>

Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

[Jakub Kicinski]

On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote:
> On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote:
> > Drop Felix from Mediatek Ethernet driver maintainers.
> > We haven't seen any tags since the initial submission.  
> []
> > diff --git a/MAINTAINERS b/MAINTAINERS  
> []
> > @@ -11165,7 +11165,6 @@ F:	Documentation/devicetree/bindings/dma/mtk-*
> >  F:	drivers/dma/mediatek/
> >  
> > 
> >  MEDIATEK ETHERNET DRIVER
> > -M:	Felix Fietkau <nbd@nbd.name>
> >  M:	John Crispin <john@phrozen.org>
> >  M:	Sean Wang <sean.wang@mediatek.com>
> >  M:	Mark Lee <Mark-MC.Lee@mediatek.com>  
> 
> I think your script is broken as there are multiple subdirectories
> for this entry and 

Quite the opposite, the script intentionally only counts contributions
only to the code under the MAINTAINERS entry. People lose interest and
move on to working on other parts of the kernel (or maybe were never
that interested in maintaining something in the first place?). 

We want to list folks who are likely to give us reviews.

> Felix is active.

Which I tried to state in the commit message as well :)

Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

[Joe Perches]

On Mon, 2021-01-11 at 09:41 -0800, Jakub Kicinski wrote:
> On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote:
> > On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote:
> > > Drop Felix from Mediatek Ethernet driver maintainers.
> > > We haven't seen any tags since the initial submission.  
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS  
> > []
> > > @@ -11165,7 +11165,6 @@ F:	Documentation/devicetree/bindings/dma/mtk-*
> > >  F:	drivers/dma/mediatek/
> > >  
> > > 
> > >  MEDIATEK ETHERNET DRIVER
> > > -M:	Felix Fietkau <nbd@nbd.name>
> > >  M:	John Crispin <john@phrozen.org>
> > >  M:	Sean Wang <sean.wang@mediatek.com>
> > >  M:	Mark Lee <Mark-MC.Lee@mediatek.com>  
> > 
> > I think your script is broken as there are multiple subdirectories
> > for this entry and 

> 
> Quite the opposite, the script intentionally only counts contributions
> only to the code under the MAINTAINERS entry.

My mistake.  I'd seen Felix's name fairly often.

I ran this command:

$ git log --pretty=oneline --since=5-years-ago --grep="-by: Felix Fietkau" drivers/net/ethernet/mediatek/
656e705243fd0c2864b89634ea16ed444ef64dc6 net-next: mediatek: add support for MT7623 ethernet

Saw that felix had worked on mediatek and then looked up files in
drivers/net with mediatek and conflated the wireless files and ethernet files.

btw: because I didn't see the script published and so can't verify what's
being done here, the MAINTAINERS file shows:

	F: *Files* and directories wildcard patterns.
	   A trailing slash includes all files and subdirectory files.
	   F:	drivers/net/	all files in and below drivers/net
	   F:	drivers/net/*	all files in drivers/net, but not below

cheers, Joe

Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

[Felix Fietkau]

On 2021-01-11 18:41, Jakub Kicinski wrote:
> On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote:
>> On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote:
>> > Drop Felix from Mediatek Ethernet driver maintainers.
>> > We haven't seen any tags since the initial submission.  
>> []
>> > diff --git a/MAINTAINERS b/MAINTAINERS  
>> []
>> > @@ -11165,7 +11165,6 @@ F:	Documentation/devicetree/bindings/dma/mtk-*
>> >  F:	drivers/dma/mediatek/
>> >  
>> > 
>> >  MEDIATEK ETHERNET DRIVER
>> > -M:	Felix Fietkau <nbd@nbd.name>
>> >  M:	John Crispin <john@phrozen.org>
>> >  M:	Sean Wang <sean.wang@mediatek.com>
>> >  M:	Mark Lee <Mark-MC.Lee@mediatek.com>  
>> 
>> I think your script is broken as there are multiple subdirectories
>> for this entry and 
> 
> Quite the opposite, the script intentionally only counts contributions
> only to the code under the MAINTAINERS entry. People lose interest and
> move on to working on other parts of the kernel (or maybe were never
> that interested in maintaining something in the first place?). 
> 
> We want to list folks who are likely to give us reviews.
> 
>> Felix is active.
> 
> Which I tried to state in the commit message as well :)
Sorry for the delayed response. I'm going to submit a bunch of work on
this driver in the near future.
The patches have already been written, just need a bit more time for
testing/review.

- Felix

Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

[Jakub Kicinski]

On Mon, 11 Jan 2021 20:21:23 +0100 Felix Fietkau wrote:
> On 2021-01-11 18:41, Jakub Kicinski wrote:
> > On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote:  
> >> On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote:  
> >> > Drop Felix from Mediatek Ethernet driver maintainers.
> >> > We haven't seen any tags since the initial submission.    
> >> []  
> >> > diff --git a/MAINTAINERS b/MAINTAINERS    
> >> []  
> >> > @@ -11165,7 +11165,6 @@ F:	Documentation/devicetree/bindings/dma/mtk-*
> >> >  F:	drivers/dma/mediatek/
> >> >  
> >> > 
> >> >  MEDIATEK ETHERNET DRIVER
> >> > -M:	Felix Fietkau <nbd@nbd.name>
> >> >  M:	John Crispin <john@phrozen.org>
> >> >  M:	Sean Wang <sean.wang@mediatek.com>
> >> >  M:	Mark Lee <Mark-MC.Lee@mediatek.com>    
> >> 
> >> I think your script is broken as there are multiple subdirectories
> >> for this entry and   
> > 
> > Quite the opposite, the script intentionally only counts contributions
> > only to the code under the MAINTAINERS entry. People lose interest and
> > move on to working on other parts of the kernel (or maybe were never
> > that interested in maintaining something in the first place?). 
> > 
> > We want to list folks who are likely to give us reviews.
> >   
> >> Felix is active.  
> > 
> > Which I tried to state in the commit message as well :)  
> Sorry for the delayed response. I'm going to submit a bunch of work on
> this driver in the near future.
> The patches have already been written, just need a bit more time for
> testing/review.

Great, I'll drop this patch from the series. 

Thanks!

Re: [PATCH net 1/9] MAINTAINERS: altx: move Jay Cliburn to CREDITS

[Jakub Kicinski]

On Sun, 10 Jan 2021 21:36:24 -0800 Chris Snook wrote:
> On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > Jay was not active in recent years and does not have plans
> > to return to work on ATLX drivers.
> >
> > Subsystem ATLX ETHERNET DRIVERS
> >   Changes 20 / 116 (17%)
> >   Last activity: 2020-02-24
> >   Jay Cliburn <jcliburn@gmail.com>:
> >   Chris Snook <chris.snook@gmail.com>:
> >     Tags ea973742140b 2020-02-24 00:00:00 1
> >   Top reviewers:
> >     [4]: andrew@lunn.ch
> >     [2]: kuba@kernel.org
> >     [2]: o.rempel@pengutronix.de
> >   INACTIVE MAINTAINER Jay Cliburn <jcliburn@gmail.com>
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> I'm overdue to be moved to CREDITS as well. I never had alx hardware,
> I no longer have atl1c or atl1e hardware, and I haven't powered on my
> atl1 or atl2 hardware in years.

Your call, obviously, but having someone familiar with the code and the
hardware look at the patches and provide Ack or Review tags is in
itself very, very helpful. There is no requirement to actually test any
of the changes or develop new features.

Re: [PATCH net 1/9] MAINTAINERS: altx: move Jay Cliburn to CREDITS

[Chris Snook]

On Mon, Jan 11, 2021 at 6:39 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Sun, 10 Jan 2021 21:36:24 -0800 Chris Snook wrote:
> > On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > > Jay was not active in recent years and does not have plans
> > > to return to work on ATLX drivers.
> > >
> > > Subsystem ATLX ETHERNET DRIVERS
> > >   Changes 20 / 116 (17%)
> > >   Last activity: 2020-02-24
> > >   Jay Cliburn <jcliburn@gmail.com>:
> > >   Chris Snook <chris.snook@gmail.com>:
> > >     Tags ea973742140b 2020-02-24 00:00:00 1
> > >   Top reviewers:
> > >     [4]: andrew@lunn.ch
> > >     [2]: kuba@kernel.org
> > >     [2]: o.rempel@pengutronix.de
> > >   INACTIVE MAINTAINER Jay Cliburn <jcliburn@gmail.com>
> > >
> > > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> >
> > I'm overdue to be moved to CREDITS as well. I never had alx hardware,
> > I no longer have atl1c or atl1e hardware, and I haven't powered on my
> > atl1 or atl2 hardware in years.
>
> Your call, obviously, but having someone familiar with the code and the
> hardware look at the patches and provide Ack or Review tags is in
> itself very, very helpful. There is no requirement to actually test any
> of the changes or develop new features.

In that case, I'm happy to keep reviewing them.

Acked-by: Chris Snook <chris.snook@gmail.com>