* [PATCH net-next] net: bareudp: simplify error paths calling dellink
@ 2021-01-11 5:29 Jakub Kicinski
2021-01-11 18:34 ` Cong Wang
2021-01-12 1:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-11 5:29 UTC (permalink / raw)
To: davem; +Cc: netdev, Jakub Kicinski, Cong Wang
bareudp_dellink() only needs the device list to hand it to
unregister_netdevice_queue(). We can pass NULL in, and
unregister_netdevice_queue() will do the unregistering.
There is no chance for batching on the error path, anyway.
Suggested-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/bareudp.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c
index 85de5f96c02b..0965d136def3 100644
--- a/drivers/net/bareudp.c
+++ b/drivers/net/bareudp.c
@@ -658,7 +658,6 @@ static int bareudp_newlink(struct net *net, struct net_device *dev,
struct netlink_ext_ack *extack)
{
struct bareudp_conf conf;
- LIST_HEAD(list_kill);
int err;
err = bareudp2info(data, &conf, extack);
@@ -676,8 +675,7 @@ static int bareudp_newlink(struct net *net, struct net_device *dev,
return 0;
err_unconfig:
- bareudp_dellink(dev, &list_kill);
- unregister_netdevice_many(&list_kill);
+ bareudp_dellink(dev, NULL);
return err;
}
@@ -729,7 +727,6 @@ struct net_device *bareudp_dev_create(struct net *net, const char *name,
{
struct nlattr *tb[IFLA_MAX + 1];
struct net_device *dev;
- LIST_HEAD(list_kill);
int err;
memset(tb, 0, sizeof(tb));
@@ -753,8 +750,7 @@ struct net_device *bareudp_dev_create(struct net *net, const char *name,
return dev;
err:
- bareudp_dellink(dev, &list_kill);
- unregister_netdevice_many(&list_kill);
+ bareudp_dellink(dev, NULL);
return ERR_PTR(err);
}
EXPORT_SYMBOL_GPL(bareudp_dev_create);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: bareudp: simplify error paths calling dellink
2021-01-11 5:29 [PATCH net-next] net: bareudp: simplify error paths calling dellink Jakub Kicinski
@ 2021-01-11 18:34 ` Cong Wang
2021-01-12 1:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2021-01-11 18:34 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: David Miller, Linux Kernel Network Developers
On Sun, Jan 10, 2021 at 9:29 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> bareudp_dellink() only needs the device list to hand it to
> unregister_netdevice_queue(). We can pass NULL in, and
> unregister_netdevice_queue() will do the unregistering.
> There is no chance for batching on the error path, anyway.
>
> Suggested-by: Cong Wang <xiyou.wangcong@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Cong Wang <xiyou.wangcong@gmail.com>
Thanks for cleaning up!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: bareudp: simplify error paths calling dellink
2021-01-11 5:29 [PATCH net-next] net: bareudp: simplify error paths calling dellink Jakub Kicinski
2021-01-11 18:34 ` Cong Wang
@ 2021-01-12 1:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-12 1:20 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, xiyou.wangcong
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sun, 10 Jan 2021 21:29:22 -0800 you wrote:
> bareudp_dellink() only needs the device list to hand it to
> unregister_netdevice_queue(). We can pass NULL in, and
> unregister_netdevice_queue() will do the unregistering.
> There is no chance for batching on the error path, anyway.
>
> Suggested-by: Cong Wang <xiyou.wangcong@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] net: bareudp: simplify error paths calling dellink
https://git.kernel.org/netdev/net-next/c/1d04ccb916ce
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-12 1:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 5:29 [PATCH net-next] net: bareudp: simplify error paths calling dellink Jakub Kicinski
2021-01-11 18:34 ` Cong Wang
2021-01-12 1:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).