From: Matteo Croce <mcroce@linux.microsoft.com>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@gmail.com>
Subject: [PATCH iproute2-next] ip: don't use program name to select command
Date: Mon, 11 Jan 2021 20:05:45 +0100 [thread overview]
Message-ID: <20210111190545.45606-1-mcroce@linux.microsoft.com> (raw)
From: Matteo Croce <mcroce@microsoft.com>
ip has an ancient behaviour of looking at its program name to determine
the command to run. If the name is longer than 2 characters, the first two
letters are stripped and the others are interpreted as the command name:
$ ln -s /sbin/ip iproute
$ ln -s /sbin/ip ipa
$ ./iproute
default via 192.168.55.1 dev wlp0s20f3 proto dhcp metric 600
192.168.55.0/24 dev wlp0s20f3 proto kernel scope link src 192.168.55.26 metric 600
192.168.122.0/24 dev virbr0 proto kernel scope link src 192.168.122.1 linkdown
$ ./ipa show dev lo
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
This creates problems when the ip binary is renamed. For example, Yocto
renames it to 'ip.iproute2' when also the busybox implementation is
present, giving the following error:
$ ip.iproute2
Object ".iproute2" is unknown, try "ip help".
Since noone is using it, remove this undocumented feature.
Signed-off-by: Matteo Croce <mcroce@microsoft.com>
---
ip/ip.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ip/ip.c b/ip/ip.c
index 40d2998a..9b772307 100644
--- a/ip/ip.c
+++ b/ip/ip.c
@@ -311,9 +311,6 @@ int main(int argc, char **argv)
rtnl_set_strict_dump(&rth);
- if (strlen(basename) > 2)
- return do_cmd(basename+2, argc, argv);
-
if (argc > 1)
return do_cmd(argv[1], argc-1, argv+1);
--
2.29.2
next reply other threads:[~2021-01-11 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 19:05 Matteo Croce [this message]
2021-01-14 3:20 ` [PATCH iproute2-next] ip: don't use program name to select command David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111190545.45606-1-mcroce@linux.microsoft.com \
--to=mcroce@linux.microsoft.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).