From: "Marek Behún" <kabel@kernel.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Vladimir Oltean <olteanv@gmail.com>,
netdev@vger.kernel.org, pavana.sharma@digi.com,
vivien.didelot@gmail.com, f.fainelli@gmail.com, kuba@kernel.org,
lkp@intel.com, davem@davemloft.net, ashkan.boldaji@digi.com,
andrew@lunn.ch, Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: [PATCH net-next v14 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell
Date: Tue, 12 Jan 2021 17:37:24 +0100 [thread overview]
Message-ID: <20210112173724.0ed8e1ec@kernel.org> (raw)
In-Reply-To: <20210112162909.GD1551@shell.armlinux.org.uk>
On Tue, 12 Jan 2021 16:29:09 +0000
Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote:
> On Tue, Jan 12, 2021 at 05:02:26PM +0100, Marek Behún wrote:
> > > > +static void mv88e6393x_phylink_validate(struct mv88e6xxx_chip *chip, int port,
> > > > + unsigned long *mask,
> > > > + struct phylink_link_state *state)
> > > > +{
> > > > + if (port == 0 || port == 9 || port == 10) {
> > > > + phylink_set(mask, 10000baseT_Full);
> > > > + phylink_set(mask, 10000baseKR_Full);
> > >
> > > I think I understand the reason for declaring 10GBase-KR support in
> > > phylink_validate, in case the PHY supports that link mode on the media
> > > side, but...
> >
> > Hmm, yes, maybe KR shouldn't be here, but then why is it in
> > mv88e6390x_phylink_validate?
>
> I'm seriously thinking about changing the phylink_validate() interface
> such that the question of which link _modes_ are supported no longer
> comes up with MAC drivers, but instead MAC drivers say what interface
> modes, speeds for each interface mode, duplexes for each speed are
> supported.
Russell, I would be happy to help with such endeavour.
next prev parent reply other threads:[~2021-01-12 16:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 1:21 [PATCH net-next v14 0/6] Add support for mv88e6393x family of Marvell Marek Behún
2021-01-11 1:21 ` [PATCH net-next v14 1/6] dt-bindings: net: Add 5GBASER phy interface Marek Behún
2021-01-11 16:41 ` Andrew Lunn
2021-01-11 1:21 ` [PATCH net-next v14 2/6] net: phy: Add 5GBASER interface mode Marek Behún
2021-01-11 16:48 ` Russell King - ARM Linux admin
2021-01-11 17:49 ` Marek Behún
2021-01-11 1:21 ` [PATCH net-next v14 3/6] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int Marek Behún
2021-01-12 10:53 ` Vladimir Oltean
2021-01-11 1:21 ` [PATCH net-next v14 4/6] net: dsa: mv88e6xxx: wrap .set_egress_port method Marek Behún
2021-01-11 5:57 ` Pavana Sharma
2021-01-12 10:53 ` Vladimir Oltean
2021-01-11 1:21 ` [PATCH net-next v14 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell Marek Behún
2021-01-12 11:11 ` Vladimir Oltean
2021-01-12 16:02 ` Marek Behún
2021-01-12 16:29 ` Russell King - ARM Linux admin
2021-01-12 16:37 ` Marek Behún [this message]
2021-01-12 18:06 ` Marek Behún
2021-01-12 21:58 ` Vladimir Oltean
2021-01-13 3:56 ` Marek Behún
2021-01-11 1:21 ` [PATCH net-next v14 6/6] net: dsa: mv88e6xxx: implement .port_set_policy for Amethyst Marek Behún
2021-01-11 6:00 ` Pavana Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112173724.0ed8e1ec@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=ashkan.boldaji@digi.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pavana.sharma@digi.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).