From: "Pali Rohár" <pali@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net
Subject: Re: [PATCH net-next v4 2/4] net: phylink: allow attaching phy for SFP modules on 802.3z mode
Date: Wed, 13 Jan 2021 11:38:41 +0100 [thread overview]
Message-ID: <20210113103841.hq2cjzf22ytgcwd7@pali> (raw)
In-Reply-To: <20210111050044.22002-3-kabel@kernel.org>
On Monday 11 January 2021 06:00:42 Marek Behún wrote:
> Some SFPs may contain an internal PHY which may in some cases want to
> connect with the host interface in 1000base-x/2500base-x mode.
> Do not fail if such PHY is being attached in one of these PHY interface
> modes.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
> Cc: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/net/phy/phylink.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 84f6e197f965..f97d041f82f4 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1018,7 +1018,7 @@ static int phylink_attach_phy(struct phylink *pl, struct phy_device *phy,
> {
> if (WARN_ON(pl->cfg_link_an_mode == MLO_AN_FIXED ||
> (pl->cfg_link_an_mode == MLO_AN_INBAND &&
> - phy_interface_mode_is_8023z(interface))))
> + phy_interface_mode_is_8023z(interface) && !pl->sfp_bus)))
> return -EINVAL;
>
> if (pl->phydev)
> @@ -2069,9 +2069,6 @@ static int phylink_sfp_config(struct phylink *pl, u8 mode,
> phylink_an_mode_str(mode), phy_modes(config.interface),
> __ETHTOOL_LINK_MODE_MASK_NBITS, support);
>
> - if (phy_interface_mode_is_8023z(iface) && pl->phydev)
> - return -EINVAL;
> -
> changed = !linkmode_equal(pl->supported, support);
> if (changed) {
> linkmode_copy(pl->supported, support);
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-01-13 10:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 5:00 [PATCH net-next v4 0/4] Support for RollBall 10G copper SFP modules Marek Behún
2021-01-11 5:00 ` [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall " Marek Behún
2021-01-12 8:42 ` Heiner Kallweit
2021-01-12 14:02 ` Andrew Lunn
2021-01-12 14:40 ` Heiner Kallweit
2021-01-12 17:49 ` Marek Behún
2021-01-12 19:22 ` Russell King - ARM Linux admin
2021-01-18 12:13 ` Pali Rohár
2021-01-18 15:45 ` Russell King - ARM Linux admin
2021-01-12 20:20 ` Andrew Lunn
2021-01-12 20:43 ` Andrew Lunn
2021-01-12 20:53 ` Marek Behún
2021-01-12 20:55 ` Andrew Lunn
2021-01-12 20:54 ` Andrew Lunn
2021-01-12 21:01 ` Marek Behún
2021-01-13 10:51 ` Pali Rohár
2021-01-12 21:22 ` Russell King - ARM Linux admin
2021-01-13 11:22 ` Pali Rohár
2021-01-13 13:56 ` Andrew Lunn
2021-01-13 13:58 ` Pali Rohár
2021-01-13 16:14 ` Russell King - ARM Linux admin
2021-01-11 5:00 ` [PATCH net-next v4 2/4] net: phylink: allow attaching phy for SFP modules on 802.3z mode Marek Behún
2021-01-13 10:38 ` Pali Rohár [this message]
2021-01-11 5:00 ` [PATCH net-next v4 3/4] net: sfp: create/destroy I2C mdiobus before PHY probe/after PHY release Marek Behún
2021-01-13 10:41 ` Pali Rohár
2021-01-11 5:00 ` [PATCH net-next v4 4/4] net: sfp: add support for multigig RollBall transceivers Marek Behún
2021-01-13 10:49 ` Pali Rohár
2021-01-13 11:08 ` Russell King - ARM Linux admin
2021-01-13 11:26 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113103841.hq2cjzf22ytgcwd7@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).