netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Cc: netdev@vger.kernel.org, Dany Madden <drt@linux.ibm.com>,
	Lijun Pan <ljp@linux.ibm.com>,
	Rick Lindsley <ricklind@linux.ibm.com>
Subject: Re: [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking
Date: Wed, 13 Jan 2021 10:57:35 -0800	[thread overview]
Message-ID: <20210113105735.20853d1f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210113044247.GA224486@us.ibm.com>

On Tue, 12 Jan 2021 20:42:47 -0800 Sukadev Bhattiprolu wrote:
> Jakub Kicinski [kuba@kernel.org] wrote:
> > On Tue, 12 Jan 2021 10:14:34 -0800 Sukadev Bhattiprolu wrote:  
> > > Use more consistent locking when reading/writing the adapter->state
> > > field. This patch set fixes a race condition during ibmvnic_open()
> > > where the adapter could be left in the PROBED state if a reset occurs
> > > at the wrong time. This can cause networking to not come up during
> > > boot and potentially require manual intervention in bringing up
> > > applications that depend on the network.  
> > 
> > Apologies for not having enough time to suggest details, but let me
> > state this again - the patches which fix bugs need to go into net with
> > Fixes tags, the refactoring needs to go to net-next without Fixes tags.
> > If there are dependencies, patches go to net first, then within a week
> > or so the reset can be posted for net-next, after net -> net-next merge.  
> 
> Well, the patch set fixes a set of bugs - main one is a locking bug fixed
> in patch 6. Other bugs are more minor or corner cases. Fixing the locking
> bug requires some refactoring/simplifying/reordering checks so lock can be
> properly acquired.
> 
> Because of the size/cleanup, should we treat it as "next" material? i.e
> should I just drop the Fixes tag and resend to net-next?
> 
> Or can we ignore the size of patchset and treat it all as bug fixes?

No, focus on doing this right rather than trying to justify why your
patches deserve special treatment.

Throw this entire series out and start over with the goal of fixing 
the bugs with minimal patches.

  reply	other threads:[~2021-01-13 18:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 18:14 [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 1/7] ibmvnic: restore state in change-param reset Sukadev Bhattiprolu
2021-01-12 18:35   ` Dany Madden
2021-01-12 18:14 ` [PATCH net-next v2 2/7] ibmvnic: update reset function prototypes Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 3/7] ibmvnic: avoid allocating rwi entries Sukadev Bhattiprolu
2021-01-12 19:48   ` Saeed Mahameed
2021-01-13  1:15     ` Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 4/7] ibmvnic: switch order of checks in ibmvnic_reset Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 5/7] ibmvnic: serialize access to work queue Sukadev Bhattiprolu
2021-01-12 19:56   ` Saeed Mahameed
2021-01-13  0:40     ` Sukadev Bhattiprolu
2021-01-13  1:56       ` Jakub Kicinski
2021-01-12 18:14 ` [PATCH net-next v2 6/7] ibmvnic: check adapter->state under state_lock Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 7/7] ibmvnic: add comments about state_lock Sukadev Bhattiprolu
2021-01-12 20:00 ` [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking Saeed Mahameed
2021-01-13  2:00 ` Jakub Kicinski
2021-01-13  4:42   ` Sukadev Bhattiprolu
2021-01-13 18:57     ` Jakub Kicinski [this message]
2021-01-13 19:55       ` Sukadev Bhattiprolu
2021-01-14  2:35   ` Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113105735.20853d1f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=drt@linux.ibm.com \
    --cc=ljp@linux.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=ricklind@linux.ibm.com \
    --cc=sukadev@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).