From: Vladimir Oltean <olteanv@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Petr Machata <petrm@nvidia.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@nvidia.com>,
vivien.didelot@gmail.com
Subject: Re: [RFC PATCH net-next 2/2] net: dsa: felix: offload port priority
Date: Thu, 14 Jan 2021 02:57:01 +0200 [thread overview]
Message-ID: <20210114005701.lgwcle3j2jypu35u@skbuf> (raw)
In-Reply-To: <62d9811f-93e4-9d9b-c159-76c35fa919dc@gmail.com>
On Wed, Jan 13, 2021 at 03:37:49PM -0800, Florian Fainelli wrote:
> You are passing the whole dsa_mall_skbedit_tc_entry structure here,
> only to look up priority, would it make sense for now to pass
> skbedit->priority as a parameter which would be matching the function
> name and what it is dealing with?
Actually I am passing a pointer to it, which should be more or less
equal in size to an integer. But I can pass just the priority, sure.
prev parent reply other threads:[~2021-01-14 1:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 15:41 [RFC PATCH net-next 0/2] Port-based priority on DSA switches using tc-matchall Vladimir Oltean
2021-01-13 15:41 ` [RFC PATCH net-next 1/2] net: dsa: allow setting port-based QoS priority using tc matchall skbedit Vladimir Oltean
2021-01-13 23:41 ` Andrew Lunn
2021-01-14 0:17 ` Vladimir Oltean
2021-01-14 1:02 ` Andrew Lunn
2022-02-10 18:53 ` Vladimir Oltean
2022-02-11 7:52 ` Petr Machata
2022-02-11 15:29 ` Vladimir Oltean
2022-02-11 16:08 ` Andrew Lunn
2022-02-11 18:24 ` Petr Machata
2022-02-17 15:42 ` Vladimir Oltean
2022-02-11 15:59 ` Andrew Lunn
2021-01-13 15:41 ` [RFC PATCH net-next 2/2] net: dsa: felix: offload port priority Vladimir Oltean
2021-01-13 23:36 ` Andrew Lunn
2021-01-13 23:37 ` Florian Fainelli
2021-01-14 0:57 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114005701.lgwcle3j2jypu35u@skbuf \
--to=olteanv@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=vivien.didelot@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).