From: Jakub Kicinski <kuba@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
syzbot+2393580080a2da190f04@syzkaller.appspotmail.com
Subject: Re: [PATCH net] net: sit: unregister_netdevice on newlink's error path
Date: Thu, 14 Jan 2021 10:27:36 -0800 [thread overview]
Message-ID: <20210114102736.037c6494@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <f7ddd59c-8446-4771-c1a6-c58819d5bcdb@6wind.com>
On Thu, 14 Jan 2021 09:49:48 +0100 Nicolas Dichtel wrote:
> Le 14/01/2021 à 02:29, Jakub Kicinski a écrit :
> [snip]
> > --- a/net/ipv6/sit.c
> > +++ b/net/ipv6/sit.c
> > @@ -1645,8 +1645,11 @@ static int ipip6_newlink(struct net *src_net, struct net_device *dev,
> > }
> >
> > #ifdef CONFIG_IPV6_SIT_6RD
> > - if (ipip6_netlink_6rd_parms(data, &ip6rd))
> > + if (ipip6_netlink_6rd_parms(data, &ip6rd)) {
> > err = ipip6_tunnel_update_6rd(nt, &ip6rd);
> > + if (err)
> nit: I would prefer 'if (err < 0)' to be consistent with the rest of the sit
> code, but it's purely aesthetic (ipip6_tunnel_update_6rd() returns a negative
> value or 0).
Done.
> With or without this:
> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Thanks for the review, applied!
prev parent reply other threads:[~2021-01-14 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 1:29 [PATCH net] net: sit: unregister_netdevice on newlink's error path Jakub Kicinski
2021-01-14 8:49 ` Nicolas Dichtel
2021-01-14 18:27 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114102736.037c6494@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=syzbot+2393580080a2da190f04@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).