Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net v3] net: macb: Add default usrio config to default gem config
@ 2021-01-13 19:36 Atish Patra
  2021-01-14  6:13 ` kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: Atish Patra @ 2021-01-13 19:36 UTC (permalink / raw)
  To: netdev
  Cc: Atish Patra, Nicolas Ferre, Claudiu Beznea, David S. Miller,
	Jakub Kicinski, Andrew Lunn

There is no usrio config defined for default gem config leading to
a kernel panic devices that don't define a data. This issue can be
reprdouced with microchip polar fire soc where compatible string
is defined as "cdns,macb".

Fixes: edac63861db7 ("net: macb: add userio bits as platform configuration")
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Atish Patra <atish.patra@wdc.com>
---
Changes from v2->v3:
1. Fixed the typo in fixes tag.
Changes from v1->v2:
1. Fixed the fixes tag.
---
 drivers/net/ethernet/cadence/macb_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 814a5b10141d..47ee72ab7002 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4590,6 +4590,7 @@ static const struct macb_config default_gem_config = {
 	.dma_burst_length = 16,
 	.clk_init = macb_clk_init,
 	.init = macb_init,
+	.usrio = &macb_default_usrio,
 	.jumbo_max_len = 10240,
 };
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net v3] net: macb: Add default usrio config to default gem config
  2021-01-13 19:36 [PATCH net v3] net: macb: Add default usrio config to default gem config Atish Patra
@ 2021-01-14  6:13 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-01-14  6:13 UTC (permalink / raw)
  To: Atish Patra, netdev
  Cc: kbuild-all, Atish Patra, Nicolas Ferre, Claudiu Beznea,
	Jakub Kicinski, Andrew Lunn


[-- Attachment #1: Type: text/plain, Size: 1812 bytes --]

Hi Atish,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Atish-Patra/net-macb-Add-default-usrio-config-to-default-gem-config/20210114-034147
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git c8a8ead01736419a14c3106e1f26a79d74fc84c7
config: x86_64-rhel-7.6-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/a870ba09ad366b8a2aa9cde42e3b0404a333ce03
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Atish-Patra/net-macb-Add-default-usrio-config-to-default-gem-config/20210114-034147
        git checkout a870ba09ad366b8a2aa9cde42e3b0404a333ce03
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/cadence/macb_main.c:4593:12: error: 'macb_default_usrio' undeclared here (not in a function)
    4593 |  .usrio = &macb_default_usrio,
         |            ^~~~~~~~~~~~~~~~~~


vim +/macb_default_usrio +4593 drivers/net/ethernet/cadence/macb_main.c

  4585	
  4586	static const struct macb_config default_gem_config = {
  4587		.caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE |
  4588				MACB_CAPS_JUMBO |
  4589				MACB_CAPS_GEM_HAS_PTP,
  4590		.dma_burst_length = 16,
  4591		.clk_init = macb_clk_init,
  4592		.init = macb_init,
> 4593		.usrio = &macb_default_usrio,
  4594		.jumbo_max_len = 10240,
  4595	};
  4596	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50543 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 19:36 [PATCH net v3] net: macb: Add default usrio config to default gem config Atish Patra
2021-01-14  6:13 ` kernel test robot

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git