From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Hauke Mehrtens <hauke@hauke-m.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Linus Walleij <linus.walleij@linaro.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [PATCH net-next] net: dsa: set configure_vlan_while_not_filtering to true by default
Date: Sat, 16 Jan 2021 01:14:58 +0200 [thread overview]
Message-ID: <20210115231458.ush3qo5lv6zk54qj@skbuf> (raw)
In-Reply-To: <20210115231248.gsebq3bqro23qz7y@skbuf>
On Sat, Jan 16, 2021 at 01:12:48AM +0200, Vladimir Oltean wrote:
> On Fri, Jan 15, 2021 at 03:03:14PM -0800, Jakub Kicinski wrote:
> > On Thu, 14 Jan 2021 19:34:26 +0200 Vladimir Oltean wrote:
> > > From: Vladimir Oltean <vladimir.oltean@nxp.com>
> > >
> > > As explained in commit 54a0ed0df496 ("net: dsa: provide an option for
> > > drivers to always receive bridge VLANs"), DSA has historically been
> > > skipping VLAN switchdev operations when the bridge wasn't in
> > > vlan_filtering mode, but the reason why it was doing that has never been
> > > clear. So the configure_vlan_while_not_filtering option is there merely
> > > to preserve functionality for existing drivers. It isn't some behavior
> > > that drivers should opt into. Ideally, when all drivers leave this flag
> > > set, we can delete the dsa_port_skip_vlan_configuration() function.
> >
> > No longer applies :(
>
> What's the error?
Never mind, I know what happened. It rebased cleanly just because git is
smart. I'll resend a v2 with the updated context.
prev parent reply other threads:[~2021-01-15 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 17:34 [PATCH net-next] net: dsa: set configure_vlan_while_not_filtering to true by default Vladimir Oltean
2021-01-15 7:11 ` Kurt Kanzenbach
2021-01-15 16:49 ` Florian Fainelli
2021-01-15 23:03 ` Jakub Kicinski
2021-01-15 23:12 ` Vladimir Oltean
2021-01-15 23:14 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115231458.ush3qo5lv6zk54qj@skbuf \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux@rempel-privat.de \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).