netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Tobias Waldekranz <tobias@waldekranz.com>,
	Maxim Kochetkov <fido_max@inbox.ru>
Subject: [PATCH v2 net-next 01/14] net: mscc: ocelot: allow offloading of bridge on top of LAG
Date: Sat, 16 Jan 2021 02:59:30 +0200	[thread overview]
Message-ID: <20210116005943.219479-2-olteanv@gmail.com> (raw)
In-Reply-To: <20210116005943.219479-1-olteanv@gmail.com>

From: Vladimir Oltean <vladimir.oltean@nxp.com>

Commit 7afb3e575e5a ("net: mscc: ocelot: don't handle netdev events for
other netdevs") was too aggressive, and it made ocelot_netdevice_event
react only to network interface events emitted for the ocelot switch
ports.

In fact, only the PRECHANGEUPPER should have had that check.

When we ignore all events that are not for us, we miss the fact that the
upper of the LAG changes, and the bonding interface gets enslaved to a
bridge. This is an operation we could offload under certain conditions.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
Changes in v2:
None.

 drivers/net/ethernet/mscc/ocelot_net.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/ethernet/mscc/ocelot_net.c
index a520fd485912..467170363ab2 100644
--- a/drivers/net/ethernet/mscc/ocelot_net.c
+++ b/drivers/net/ethernet/mscc/ocelot_net.c
@@ -1153,10 +1153,8 @@ static int ocelot_netdevice_event(struct notifier_block *unused,
 	struct net_device *dev = netdev_notifier_info_to_dev(ptr);
 	int ret = 0;
 
-	if (!ocelot_netdevice_dev_check(dev))
-		return 0;
-
 	if (event == NETDEV_PRECHANGEUPPER &&
+	    ocelot_netdevice_dev_check(dev) &&
 	    netif_is_lag_master(info->upper_dev)) {
 		struct netdev_lag_upper_info *lag_upper_info = info->upper_info;
 		struct netlink_ext_ack *extack;
-- 
2.25.1


  reply	other threads:[~2021-01-16  1:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16  0:59 [PATCH v2 net-next 00/14] LAG offload for Ocelot DSA switches Vladimir Oltean
2021-01-16  0:59 ` Vladimir Oltean [this message]
2021-01-17  1:26   ` [PATCH v2 net-next 01/14] net: mscc: ocelot: allow offloading of bridge on top of LAG Jakub Kicinski
2021-01-17 12:37     ` Vladimir Oltean
2021-01-18 19:04       ` Jakub Kicinski
2021-01-18 19:35         ` Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 02/14] net: mscc: ocelot: rename ocelot_netdevice_port_event to ocelot_netdevice_changeupper Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 03/14] net: mscc: ocelot: use a switch-case statement in ocelot_netdevice_event Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 04/14] net: mscc: ocelot: don't refuse bonding interfaces we can't offload Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 05/14] net: mscc: ocelot: use ipv6 in the aggregation code Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 06/14] net: mscc: ocelot: set up the bonding mask in a way that avoids a net_device Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 07/14] net: mscc: ocelot: avoid unneeded "lp" variable in LAG join Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 08/14] net: mscc: ocelot: use "lag" variable name in ocelot_bridge_stp_state_set Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 09/14] net: mscc: ocelot: reapply bridge forwarding mask on bonding join/leave Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 10/14] net: mscc: ocelot: set up logical port IDs centrally Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 11/14] net: mscc: ocelot: drop the use of the "lags" array Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 12/14] net: mscc: ocelot: rename aggr_count to num_ports_in_lag Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 13/14] net: mscc: ocelot: rebalance LAGs on link up/down events Vladimir Oltean
2021-01-16  0:59 ` [PATCH v2 net-next 14/14] net: dsa: felix: propagate the LAG offload ops towards the ocelot lib Vladimir Oltean
2021-01-16 15:51 ` [PATCH v2 net-next 00/14] LAG offload for Ocelot DSA switches Vladimir Oltean
2021-01-17  1:25   ` Jakub Kicinski
2021-01-17  1:58     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210116005943.219479-2-olteanv@gmail.com \
    --to=olteanv@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=fido_max@inbox.ru \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tobias@waldekranz.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).