From: Jakub Kicinski <kuba@kernel.org>
To: Bhaskar Upadhaya <bupadhaya@marvell.com>
Cc: <netdev@vger.kernel.org>, <aelior@marvell.com>, <irusskikh@marvell.com>
Subject: Re: [PATCH net-next 3/3] qede: set default per queue rx/tx usecs coalescing parameters
Date: Sat, 16 Jan 2021 18:28:06 -0800 [thread overview]
Message-ID: <20210116182806.625c540e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1610701570-29496-4-git-send-email-bupadhaya@marvell.com>
On Fri, 15 Jan 2021 01:06:10 -0800 Bhaskar Upadhaya wrote:
> Here we do the initialization of coalescing values on load.
> Although the default device values are the same - explicit
> config is better visible.
Can you also make the driver store the settings across ifdown / ifup
and allow the settings to be checked while the interface is down,
while at it?
next prev parent reply other threads:[~2021-01-17 2:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 9:06 [PATCH net-next 0/3] qede: add netpoll and per-queue coalesce support Bhaskar Upadhaya
2021-01-15 9:06 ` [PATCH net-next 1/3] qede: add netpoll support for qede driver Bhaskar Upadhaya
2021-01-17 2:26 ` Jakub Kicinski
2021-01-17 16:35 ` [EXT] " Igor Russkikh
2021-01-18 19:10 ` Jakub Kicinski
2021-01-15 9:06 ` [PATCH net-next 2/3] qede: add per queue coalesce " Bhaskar Upadhaya
2021-01-15 9:06 ` [PATCH net-next 3/3] qede: set default per queue rx/tx usecs coalescing parameters Bhaskar Upadhaya
2021-01-17 2:28 ` Jakub Kicinski [this message]
2021-01-17 16:37 ` [EXT] " Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210116182806.625c540e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=bupadhaya@marvell.com \
--cc=irusskikh@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).