netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tariq Toukan <tariqt@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Boris Pismenny <borisp@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <ttoukan.linux@gmail.com>,
	Moshe Shemesh <moshe@nvidia.com>,
	Jay Vosburgh <j.vosburgh@gmail.com>,
	Veaceslav Falico <vfalico@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	John Fastabend <john.fastabend@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jarod Wilson <jarod@redhat.com>, Ivan Vecera <ivecera@redhat.com>,
	Tariq Toukan <tariqt@nvidia.com>
Subject: [PATCH net-next V3 8/8] net/tls: Except bond interface from some TLS checks
Date: Sun, 17 Jan 2021 16:59:49 +0200	[thread overview]
Message-ID: <20210117145949.8632-9-tariqt@nvidia.com> (raw)
In-Reply-To: <20210117145949.8632-1-tariqt@nvidia.com>

In the tls_dev_event handler, ignore tlsdev_ops requirement for bond
interfaces, they do not exist as the interaction is done directly with
the lower device.

Also, make the validate function pass when it's called with the upper
bond interface.

Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Boris Pismenny <borisp@nvidia.com>
---
 net/tls/tls_device.c          | 2 ++
 net/tls/tls_device_fallback.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index 75ceea0a41bf..d9cd229aa111 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -1329,6 +1329,8 @@ static int tls_dev_event(struct notifier_block *this, unsigned long event,
 	switch (event) {
 	case NETDEV_REGISTER:
 	case NETDEV_FEAT_CHANGE:
+		if (netif_is_bond_master(dev))
+			return NOTIFY_DONE;
 		if ((dev->features & NETIF_F_HW_TLS_RX) &&
 		    !dev->tlsdev_ops->tls_dev_resync)
 			return NOTIFY_BAD;
diff --git a/net/tls/tls_device_fallback.c b/net/tls/tls_device_fallback.c
index d946817ed065..cacf040872c7 100644
--- a/net/tls/tls_device_fallback.c
+++ b/net/tls/tls_device_fallback.c
@@ -424,7 +424,7 @@ struct sk_buff *tls_validate_xmit_skb(struct sock *sk,
 				      struct net_device *dev,
 				      struct sk_buff *skb)
 {
-	if (dev == tls_get_ctx(sk)->netdev)
+	if (dev == tls_get_ctx(sk)->netdev || netif_is_bond_master(dev))
 		return skb;
 
 	return tls_sw_fallback(sk, skb);
-- 
2.21.0


  parent reply	other threads:[~2021-01-17 15:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-17 14:59 [PATCH net-next V3 0/8] TLS device offload for Bond Tariq Toukan
2021-01-17 14:59 ` [PATCH net-next V3 1/8] net: netdevice: Add operation ndo_sk_get_lower_dev Tariq Toukan
2021-01-17 14:59 ` [PATCH net-next V3 2/8] net/bonding: Take IP hash logic into a helper Tariq Toukan
2021-01-17 14:59 ` [PATCH net-next V3 3/8] net/bonding: Implement ndo_sk_get_lower_dev Tariq Toukan
2021-01-17 14:59 ` [PATCH net-next V3 4/8] net/bonding: Take update_features call out of XFRM funciton Tariq Toukan
2021-01-17 14:59 ` [PATCH net-next V3 5/8] net/bonding: Implement TLS TX device offload Tariq Toukan
2021-01-17 14:59 ` [PATCH net-next V3 6/8] net/bonding: Declare TLS RX device offload support Tariq Toukan
2021-01-17 14:59 ` [PATCH net-next V3 7/8] net/tls: Device offload to use lowest netdevice in chain Tariq Toukan
2021-01-17 14:59 ` Tariq Toukan [this message]
2021-01-19  5:50 ` [PATCH net-next V3 0/8] TLS device offload for Bond patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210117145949.8632-9-tariqt@nvidia.com \
    --to=tariqt@nvidia.com \
    --cc=andy@greyhouse.net \
    --cc=borisp@nvidia.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=ivecera@redhat.com \
    --cc=j.vosburgh@gmail.com \
    --cc=jarod@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=moshe@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=ttoukan.linux@gmail.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).