From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Parav Pandit <parav@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
<linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH rdma-rc] Revert "RDMA/mlx5: Fix devlink deadlock on net namespace deletion"
Date: Tue, 19 Jan 2021 20:25:21 -0400 [thread overview]
Message-ID: <20210120002521.GA963641@nvidia.com> (raw)
In-Reply-To: <20210117092633.10690-1-leon@kernel.org>
On Sun, Jan 17, 2021 at 11:26:33AM +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav@nvidia.com>
>
> This reverts commit fbdd0049d98d44914fc57d4b91f867f4996c787b.
>
> Due to commit in fixes tag, netdevice events were received only
> in one net namespace of mlx5_core_dev. Due to this when netdevice
> events arrive in net namespace other than net namespace of mlx5_core_dev,
> they are missed.
>
> This results in empty GID table due to RDMA device being detached from
> its net device.
>
> Hence, revert back to receive netdevice events in all net namespaces to
> restore back RDMA functionality in non init_net net namespace.
>
> Fixes: fbdd0049d98d ("RDMA/mlx5: Fix devlink deadlock on net namespace deletion")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 6 ++----
> .../net/ethernet/mellanox/mlx5/core/lib/mlx5.h | 5 +++++
> include/linux/mlx5/driver.h | 18 ------------------
> 3 files changed, 7 insertions(+), 22 deletions(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2021-01-20 0:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 9:26 [PATCH rdma-rc] Revert "RDMA/mlx5: Fix devlink deadlock on net namespace deletion" Leon Romanovsky
2021-01-20 0:25 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120002521.GA963641@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).