From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42797C433E0 for ; Thu, 21 Jan 2021 05:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E155622248 for ; Thu, 21 Jan 2021 05:17:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727127AbhAUFQw (ORCPT ); Thu, 21 Jan 2021 00:16:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:46532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726416AbhAUFGx (ORCPT ); Thu, 21 Jan 2021 00:06:53 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C4CD5238D7; Thu, 21 Jan 2021 05:05:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611205555; bh=IqdTpuPyQpVOz99F9S5B33fV5ykceVp/OmS7a6OWS+E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QhV7nkVr4Yr+jM00Iy+KKIRHTkuIUoCv673wta2rJ7BrevFEDbxaEpciEzH2rIbDa MXuhF0sBF5eqi5G/aV3xESfn0mZ9OTG756mtWgyHd1vNOFwK4aohMXszitgCFyDeMh d5FMh9SCGK6Kd+l+D6AvLo2kkbDONa973FtDYsnMaAgZV5GpaNdZCLLetgoSPso1aV l4cQ3DPLQEvK2Yzp1APJKkTaBQ9dGWam1KQpB7SjTuQoabHaxqwIiKLc9qgziXpaym h0zTLqOyX6SjeH5yWZw4MfGC8GOvujqSXw+AxItOXpb4P9GWmFbc2VYZbHDBi5jPzB jbQPDzxvcqU5g== Date: Wed, 20 Jan 2021 21:05:53 -0800 From: Jakub Kicinski To: Edwin Peer Cc: "David S . Miller" , netdev Subject: Re: [PATCH net-next v2 0/4] net: inline rollback_registered() functions Message-ID: <20210120210553.3c7584c2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20210119202521.3108236-1-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 19 Jan 2021 15:18:46 -0800 Edwin Peer wrote: > On Tue, Jan 19, 2021 at 12:32 PM Jakub Kicinski wrote: > > > After recent changes to the error path of register_netdevice() > > we no longer need a version of unregister_netdevice_many() which > > does not set net_todo. We can inline the rollback_registered() > > functions into respective unregister_netdevice() calls. > > > > v2: - add missing list_del() in the last patch > > > > Jakub Kicinski (4): > > net: move net_set_todo inside rollback_registered() > > net: inline rollback_registered() > > net: move rollback_registered_many() > > net: inline rollback_registered_many() > > > > net/core/dev.c | 210 +++++++++++++++++++++++-------------------------- > > 1 file changed, 98 insertions(+), 112 deletions(-) > > Reviewed-by: Edwin Peer Applied, thanks!