From: Su Yanjun <suyanjun218@gmail.com>
To: mkl@pengutronix.de, manivannan.sadhasivam@linaro.org,
thomas.kopp@microchip.com, wg@grandegger.com,
davem@davemloft.net, kuba@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Su Yanjun <suyanjun218@gmail.com>
Subject: [PATCH v1] can: mcp251xfd: use regmap_bulk_write for compatibility
Date: Fri, 22 Jan 2021 11:02:14 +0800 [thread overview]
Message-ID: <20210122030214.166334-1-suyanjun218@gmail.com> (raw)
Recently i use mcp2518fd on 4.x kernel which multiple write is not
backported, regmap_raw_write will cause old kernel crash because the
tx buffer in driver is smaller then 2K. Use regmap_bulk_write instead
for compatibility.
Signed-off-by: Su Yanjun <suyanjun218@gmail.com>
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
index 3dde52669343..ab8aad0a7594 100644
--- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
+++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
@@ -932,6 +932,7 @@ static int mcp251xfd_chip_ecc_init(struct mcp251xfd_priv *priv)
void *ram;
u32 val = 0;
int err;
+ int val_bytes = regmap_get_val_bytes(priv->map_reg);
ecc->ecc_stat = 0;
@@ -947,8 +948,8 @@ static int mcp251xfd_chip_ecc_init(struct mcp251xfd_priv *priv)
if (!ram)
return -ENOMEM;
- err = regmap_raw_write(priv->map_reg, MCP251XFD_RAM_START, ram,
- MCP251XFD_RAM_SIZE);
+ err = regmap_bulk_write(priv->map_reg, MCP251XFD_RAM_START, ram,
+ MCP251XFD_RAM_SIZE / val_bytes);
kfree(ram);
return err;
--
2.25.1
next reply other threads:[~2021-01-22 3:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 3:02 Su Yanjun [this message]
2021-01-22 7:26 ` [PATCH v1] can: mcp251xfd: use regmap_bulk_write for compatibility Marc Kleine-Budde
2021-01-22 7:59 ` Su
2021-01-22 8:14 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122030214.166334-1-suyanjun218@gmail.com \
--to=suyanjun218@gmail.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=thomas.kopp@microchip.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).