From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F58C433DB for ; Sat, 23 Jan 2021 02:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEEEC23B26 for ; Sat, 23 Jan 2021 02:15:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbhAWCP3 (ORCPT ); Fri, 22 Jan 2021 21:15:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:34770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbhAWCP1 (ORCPT ); Fri, 22 Jan 2021 21:15:27 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 64BB523B26; Sat, 23 Jan 2021 02:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611368086; bh=NladMq7QFe6GyN9y0s7oL87Je19OgCNJZS0X/MI1Uuo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mf6+IF7a/V2Q06BHxc/mLAvPENpqhi5SDnB5I9YjlyqVWNe/jenByRMEeBGDGXmv3 RzrexoALAWQ2Xn/MqQKjWsjWm/4GuzI+RbXNWcVqKkTHZecaORIDAvdGdTT0dzm1qn V9YUoHc3it1jfQzJK/iQzczEoWW0A3NZ94P4zEoR8S1ccT6abeQwk73GN4+mc4wu7h lQqCZcZYBu1KRxzjg+LtoxfpQlyg8R5xiW9VxylQwoIvMzxbJy440lTtk2Ad4owaEp UioHQzeRRDv2mSGZw+ISKWJfQpilhy/yZbUtJFPhXPphsPz6gjcujoICJkdvHXhitp yTvxzzObqfvsQ== Date: Fri, 22 Jan 2021 18:14:44 -0800 From: Jakub Kicinski To: Russell King - ARM Linux admin Cc: Richard Cochran , netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Marc Zyngier , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Vivien Didelot , Dinh Nguyen , Brandon Streiff , Olof Johansson , Vladimir Oltean , David Miller , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency. Message-ID: <20210122181444.66f9417d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210121150802.GB20321@hoboy.vegasvil.org> References: <1069fecd4b7e13485839e1c66696c5a6c70f6144.1611198584.git.richardcochran@gmail.com> <20210121102753.GO1551@shell.armlinux.org.uk> <20210121150802.GB20321@hoboy.vegasvil.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote: > On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote: > > On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote: > > > The mvpp2 is an Ethernet driver, and it implements MAC style time > > > stamping of PTP frames. It has no need of the expensive option to > > > enable PHY time stamping. Remove the incorrect dependency. > > > > > > Signed-off-by: Richard Cochran > > > Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support") > > > > NAK. > > Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING? Russell, I think we all agree now this is not the solution to the problem of which entity should provide the timestamp, but the series doesn't seem objectionable in itself. Please LMK if you think otherwise. (I would put it in net-next tho, given the above this at most a space optimization.)