From: Jonas Bonn <jonas@norrbonn.se>
To: laforge@gnumonks.org, netdev@vger.kernel.org, pbshelar@fb.com,
kuba@kernel.org
Cc: pablo@netfilter.org, Jonas Bonn <jonas@norrbonn.se>
Subject: [RFC PATCH 15/16] gtp: add ability to send GTP controls headers
Date: Sat, 23 Jan 2021 20:59:15 +0100 [thread overview]
Message-ID: <20210123195916.2765481-16-jonas@norrbonn.se> (raw)
In-Reply-To: <20210123195916.2765481-1-jonas@norrbonn.se>
From: Pravin B Shelar <pbshelar@fb.com>
Please explain how this patch actually works... creation of the control
header makes sense, but I don't understand how sending of a
control header is actually triggered.
Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
---
drivers/net/gtp.c | 43 ++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 668ed8a4836e..bbce2671de2d 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -683,6 +683,38 @@ static void gtp_push_header(struct sk_buff *skb, struct pdp_ctx *pctx,
}
}
+static inline int gtp1_push_control_header(struct sk_buff *skb,
+ struct pdp_ctx *pctx,
+ struct gtpu_metadata *opts,
+ struct net_device *dev)
+{
+ struct gtp1_header *gtp1c;
+ int payload_len;
+
+ if (opts->ver != GTP_METADATA_V1)
+ return -ENOENT;
+
+ if (opts->type == 0xFE) {
+ /* for end marker ignore skb data. */
+ netdev_dbg(dev, "xmit pkt with null data");
+ pskb_trim(skb, 0);
+ }
+ if (skb_cow_head(skb, sizeof(*gtp1c)) < 0)
+ return -ENOMEM;
+
+ payload_len = skb->len;
+
+ gtp1c = skb_push(skb, sizeof(*gtp1c));
+
+ gtp1c->flags = opts->flags;
+ gtp1c->type = opts->type;
+ gtp1c->length = htons(payload_len);
+ gtp1c->tid = htonl(pctx->u.v1.o_tei);
+ netdev_dbg(dev, "xmit control pkt: ver %d flags %x type %x pkt len %d tid %x",
+ opts->ver, opts->flags, opts->type, skb->len, pctx->u.v1.o_tei);
+ return 0;
+}
+
static int gtp_xmit_ip4(struct sk_buff *skb, struct net_device *dev)
{
struct gtp_dev *gtp = netdev_priv(dev);
@@ -807,7 +839,16 @@ static int gtp_xmit_ip4(struct sk_buff *skb, struct net_device *dev)
skb_set_inner_protocol(skb, skb->protocol);
- gtp_push_header(skb, pctx, &port);
+ if (unlikely(opts)) {
+ port = htons(GTP1U_PORT);
+ r = gtp1_push_control_header(skb, pctx, opts, dev);
+ if (r) {
+ netdev_info(dev, "cntr pkt error %d", r);
+ goto err_rt;
+ }
+ } else {
+ gtp_push_header(skb, pctx, &port);
+ }
iph = ip_hdr(skb);
netdev_dbg(dev, "gtp -> IP src: %pI4 dst: %pI4\n",
--
2.27.0
next prev parent reply other threads:[~2021-01-23 20:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 19:59 [RFC PATCH 00/16] GTP: flow based Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 01/16] Revert "GTP: add support for flow based tunneling API" Jonas Bonn
2021-01-24 16:34 ` Harald Welte
2021-01-23 19:59 ` [RFC PATCH 02/16] gtp: set initial MTU Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 03/16] gtp: include role in link info Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 04/16] gtp: really check namespaces before xmit Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 05/16] gtp: drop unnecessary call to skb_dst_drop Jonas Bonn
2021-01-24 16:48 ` Harald Welte
2021-01-23 19:59 ` [RFC PATCH 06/16] gtp: set device type Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 07/16] gtp: rework IPv4 functionality Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 08/16] gtp: set dev features to enable GSO Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 09/16] gtp: support GRO Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 10/16] gtp: refactor check_ms back into version specific handlers Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 11/16] gtp: drop duplicated assignment Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 12/16] gtp: update rx_length_errors for abnormally short packets Jonas Bonn
2021-01-24 16:50 ` Harald Welte
2021-01-23 19:59 ` [RFC PATCH 13/16] gtp: set skb protocol after pulling headers Jonas Bonn
2021-01-23 19:59 ` [RFC PATCH 14/16] gtp: add support for flow based tunneling Jonas Bonn
2021-01-24 14:27 ` Jonas Bonn
2021-01-24 15:11 ` Jonas Bonn
2021-01-25 8:12 ` Jonas Bonn
2021-01-25 8:47 ` Jonas Bonn
2021-02-06 18:04 ` Jonas Bonn
2021-02-07 17:56 ` Pravin Shelar
2021-01-23 19:59 ` Jonas Bonn [this message]
2021-01-24 14:21 ` [RFC PATCH 15/16] gtp: add ability to send GTP controls headers Jonas Bonn
2021-01-25 17:41 ` Harald Welte
2021-01-28 21:29 ` Pravin Shelar
2021-01-28 21:29 ` Pravin Shelar
[not found] ` <9b9476d2-186f-e749-f17d-d191c30347e4@norrbonn.se>
2021-01-30 6:59 ` Pravin Shelar
2021-01-30 18:44 ` Jakub Kicinski
2021-01-30 20:05 ` Pravin Shelar
2021-02-01 20:44 ` Jakub Kicinski
2021-02-02 5:24 ` Jonas Bonn
2021-02-02 6:56 ` Pravin Shelar
2021-02-02 8:03 ` Jonas Bonn
2021-02-02 22:54 ` Pravin Shelar
2021-01-23 19:59 ` [RFC PATCH 16/16] gtp: add netlink support for setting up flow based tunnels Jonas Bonn
2021-01-24 17:42 ` [RFC PATCH 00/16] GTP: flow based Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123195916.2765481-16-jonas@norrbonn.se \
--to=jonas@norrbonn.se \
--cc=kuba@kernel.org \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pbshelar@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).