From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F9F0C433DB for ; Mon, 25 Jan 2021 18:31:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F77822D50 for ; Mon, 25 Jan 2021 18:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbhAYSbM (ORCPT ); Mon, 25 Jan 2021 13:31:12 -0500 Received: from mail-40136.protonmail.ch ([185.70.40.136]:35521 "EHLO mail-40136.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726886AbhAYS2V (ORCPT ); Mon, 25 Jan 2021 13:28:21 -0500 Date: Mon, 25 Jan 2021 18:27:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1611599255; bh=BNsVpptmPCWnM/HSD7DFkyRUhexA9u11ZFBtrI8eXBw=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=aw2vpID7+/tcFGlQBlD9SjxMuz+grORCsiUs4coVpZPWcuIL3pf1vkiYfr2JRZaZT EwhVJPGp3/tZwXNjCo8HiBvRNB9hO/AUA499dNaBjQzn5xAam5Sfdypp43gCxrTBsx nZWz6AhMji7ekBopTmogGQmAm02Ir/+PZU0xCzWxobwLTcq9S+o+av/RuMqjxh1qno jCu7otS0DW5MtXXM5XrHrcf1DWg4fRB1uVvyBRofxLUGowVVNpS5WgGrNWzJDCPpP+ Yu5v0rgcUcRC4wejN4NhYEol36SE9E3WINOxv3ldpJtKfmAAbgK7gv9F42sBHN7c8x bc+pB4ZowJz6Q== To: David Rientjes From: Alexander Lobakin Cc: Alexander Lobakin , "David S. Miller" , Jakub Kicinski , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Reply-To: Alexander Lobakin Subject: Re: [PATCH net-next 2/3] net: constify page_is_pfmemalloc() argument at call sites Message-ID: <20210125182702.247232-1-alobakin@pm.me> In-Reply-To: <85978330-9753-f7a-f263-7a1cfd95b851@google.com> References: <20210125164612.243838-1-alobakin@pm.me> <20210125164612.243838-3-alobakin@pm.me> <85978330-9753-f7a-f263-7a1cfd95b851@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Rientjes Date: Mon, 25 Jan 2021 10:19:48 -0800 (PST) > On Mon, 25 Jan 2021, Alexander Lobakin wrote: >=20 > > Constify "page" argument for page_is_pfmemalloc() users where applicabl= e. > > > > Signed-off-by: Alexander Lobakin > > --- > > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- > > drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- > > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +- > > drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- > > drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- > > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- > > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- > > drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- > > include/linux/skbuff.h | 4 ++-- > > 11 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/= net/ethernet/hisilicon/hns3/hns3_enet.c > > index 512080640cbc..0f8e962b5010 100644 > > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > > @@ -2800,7 +2800,7 @@ static void hns3_nic_alloc_rx_buffers(struct hns3= _enet_ring *ring, > > =09writel(i, ring->tqp->io_base + HNS3_RING_RX_RING_HEAD_REG); > > } > > > > -static bool hns3_page_is_reusable(struct page *page) > > +static bool hns3_page_is_reusable(const struct page *page) > > { > > =09return page_to_nid(page) =3D=3D numa_mem_id() && > > =09=09!page_is_pfmemalloc(page); >=20 > Hi Alexander, Hi David! > All of these functions appear to be doing the same thing, would it make > sense to simply add this to a header file and remove all the code > duplication as well? That's an interesting idea. I'll be glad to do this if drivers' maintainers agree it's okay for them. Thanks, Al