From: Phil Sutter <phil@nwl.cc>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, netdev@vger.kernel.org
Subject: Re: [iproute PATCH] tc: u32: Fix key folding in sample option
Date: Thu, 4 Feb 2021 15:04:50 +0100 [thread overview]
Message-ID: <20210204140450.GS3158@orbyte.nwl.cc> (raw)
In-Reply-To: <6948a2a9-1ed2-ce8d-daeb-601c425e1258@mojatatu.com>
Jamal,
On Thu, Feb 04, 2021 at 08:19:55AM -0500, Jamal Hadi Salim wrote:
> I couldnt tell by inspection if what used to work before continues to.
> In particular the kernel version does consider the divisor when folding.
That's correct. And so does tc. What's the matter?
> Two examples that currently work, if you can try them:
Both lack information about the used hashkey and divisor.
> Most used scheme:
> ---
> tc filter add dev $DEV parent 999:0 protocol ip prio 10 u32 \
> ht 2:: \
> sample ip protocol 1 0xff match ip src 1.2.3.4/32 flowid 1:10 \
> action ok
> ----
htid before: 0x201000
htid after: 0x201000
>
> and this i also found in one of my scripts:
> ----
> tc filter add dev $DEV parent 999:0 protocol ip prio 10 u32 \
> ht 2:: \
> sample u32 0x00000806 0x0000ffff at 12 \
> match u32 0x00000800 0x0000ff00 at 12 flowid 1:10 \
> action ok
> ----
htid before: 0x20e000 (0x8 ^ 0x6 = 0xe)
htid after: 0x206000
Are you sure this still works with current kernel and iproute2
(excluding my patch)? What divisor and hashkey is used?
> Probably a simple meaning of "working" is:
> the values before and after (your changes) are consistent.
>
> If also you will do us a kindness and add maybe a testcase in tdc?
> This way next person wanting to fix it can run the tests first before
> posting a patch.
What is "tdc"?
Cheers, Phil
next prev parent reply other threads:[~2021-02-04 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 18:30 [iproute PATCH] tc: u32: Fix key folding in sample option Phil Sutter
2021-02-04 13:19 ` Jamal Hadi Salim
2021-02-04 14:04 ` Phil Sutter [this message]
2021-02-04 14:34 ` Jamal Hadi Salim
2021-02-04 14:36 ` Jamal Hadi Salim
2021-02-04 14:50 ` Phil Sutter
2021-02-04 15:28 ` Jamal Hadi Salim
2021-02-04 16:50 ` Phil Sutter
2021-02-04 18:08 ` Jamal Hadi Salim
2021-07-05 14:17 ` Phil Sutter
2021-07-05 17:25 ` Jamal Hadi Salim
2021-08-03 16:42 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204140450.GS3158@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).