From: Jakub Kicinski <kuba@kernel.org>
To: George McCollister <george.mccollister@gmail.com>,
Tobias Waldekranz <tobias@waldekranz.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: xrs700x: Correctly address device over I2C
Date: Thu, 4 Feb 2021 19:11:49 -0800 [thread overview]
Message-ID: <20210204191149.2eecf944@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAFSKS=OtcuJRF=8rK-3dUU0=G-k=JciLsdrhS5B9t9oWz1Y2Gw@mail.gmail.com>
On Tue, 2 Feb 2021 14:05:20 -0600 George McCollister wrote:
> On Tue, Feb 2, 2021 at 1:17 PM Tobias Waldekranz <tobias@waldekranz.com> wrote:
> [snip]
> >
> > George, have you used the chip in I2C mode with the code that is on
> > net-next now? I was not able to get the driver to even read the ID
> > register correctly.
>
> I wrote the i2c driver before I had any hardware in hand thinking I
> was going to get a board with the switch connected via i2c. When the
> board arrived it turned out it was connected via mdio so I wrote that
> driver as well. I looked it over quite carefully but I guess the
> documentation was wrong and I had the register addresses shifted off
> by one. I never ended up with hardware to test the i2c.
> Reviewed-by: George McCollister <george.mccollister@gmail.com>
Applied, thanks!
prev parent reply other threads:[~2021-02-05 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 19:16 [PATCH net-next] net: dsa: xrs700x: Correctly address device over I2C Tobias Waldekranz
2021-02-02 20:05 ` George McCollister
2021-02-05 3:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204191149.2eecf944@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).