From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: ucan: fix alignment constraints
Date: Mon, 8 Feb 2021 14:16:24 +0100 [thread overview]
Message-ID: <20210208131624.y5ro74e4fibpg6rk@hardanger.blackshift.org> (raw)
In-Reply-To: <20210204162625.3099392-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On 04.02.2021 17:26:13, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> struct ucan_message_in contains member with 4-byte alignment
> but is itself marked as unaligned, which triggers a warning:
>
> drivers/net/can/usb/ucan.c:249:1: warning: alignment 1 of 'struct ucan_message_in' is less than 4 [-Wpacked-not-aligned]
>
> Mark the outer structure to have the same alignment as the inner
> one.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to linux-can-next/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-08 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 16:26 [PATCH] can: ucan: fix alignment constraints Arnd Bergmann
2021-02-08 13:16 ` Marc Kleine-Budde [this message]
2021-02-09 10:34 ` David Laight
2021-02-09 11:28 ` Marc Kleine-Budde
2021-02-09 13:53 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208131624.y5ro74e4fibpg6rk@hardanger.blackshift.org \
--to=mkl@pengutronix.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).