From: kernel test robot <lkp@intel.com>
To: Taehee Yoo <ap420073@gmail.com>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
dsahern@kernel.org, xiyou.wangcong@gmail.com
Cc: kbuild-all@lists.01.org, ap420073@gmail.com
Subject: Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros
Date: Tue, 9 Feb 2021 09:55:50 +0800 [thread overview]
Message-ID: <202102090915.mQU3zE2r-lkp@intel.com> (raw)
In-Reply-To: <20210208175820.5690-1-ap420073@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3626 bytes --]
Hi Taehee,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/0631c9a306555a1d9ee0aefbd7a0cdc892719dd6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339
git checkout 0631c9a306555a1d9ee0aefbd7a0cdc892719dd6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
net/ipv6/mcast.c: In function 'ip6_mc_del_src':
>> net/ipv6/mcast.c:2150:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]
2150 | int i, err, rv;
| ^
net/ipv6/mcast.c: In function 'ip6_mc_del_src_bulk':
net/ipv6/mcast.c:2218:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]
2218 | int i, rv;
| ^
vim +/i +2150 net/ipv6/mcast.c
2143
2144 static int ip6_mc_del_src(struct inet6_dev *idev, const struct in6_addr *mca,
2145 int sfmode, const struct in6_addr *psfsrc, int delta)
2146 {
2147 struct ifmcaddr6 *mc;
2148 bool found = false;
2149 int changerec = 0;
> 2150 int i, err, rv;
2151
2152 if (!idev)
2153 return -ENODEV;
2154
2155 read_lock_bh(&idev->lock);
2156 list_for_each_entry(mc, &idev->mc_list, list) {
2157 if (ipv6_addr_equal(mca, &mc->mca_addr)) {
2158 found = true;
2159 break;
2160 }
2161 }
2162 if (!found) {
2163 /* MCA not found?? bug */
2164 read_unlock_bh(&idev->lock);
2165 return -ESRCH;
2166 }
2167 spin_lock_bh(&mc->mca_lock);
2168 sf_markstate(mc);
2169 if (!delta) {
2170 if (!mc->mca_sfcount[sfmode]) {
2171 spin_unlock_bh(&mc->mca_lock);
2172 read_unlock_bh(&idev->lock);
2173 return -EINVAL;
2174 }
2175 mc->mca_sfcount[sfmode]--;
2176 }
2177 err = 0;
2178 i = 0;
2179
2180 if (psfsrc) {
2181 rv = ip6_mc_del1_src(mc, sfmode, psfsrc);
2182
2183 changerec |= rv > 0;
2184 if (!err && rv < 0)
2185 err = rv;
2186 }
2187
2188 if (mc->mca_sfmode == MCAST_EXCLUDE &&
2189 mc->mca_sfcount[MCAST_EXCLUDE] == 0 &&
2190 mc->mca_sfcount[MCAST_INCLUDE]) {
2191 struct ip6_sf_list *psf;
2192
2193 /* filter mode change */
2194 mc->mca_sfmode = MCAST_INCLUDE;
2195 mc->mca_crcount = idev->mc_qrv;
2196 idev->mc_ifc_count = mc->mca_crcount;
2197 list_for_each_entry(psf, &mc->mca_source_list, list)
2198 psf->sf_crcount = 0;
2199 mld_ifc_event(mc->idev);
2200 } else if (sf_setstate(mc) || changerec) {
2201 mld_ifc_event(mc->idev);
2202 }
2203 spin_unlock_bh(&mc->mca_lock);
2204 read_unlock_bh(&idev->lock);
2205 return err;
2206 }
2207
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69939 bytes --]
prev parent reply other threads:[~2021-02-09 1:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 17:58 [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros Taehee Yoo
2021-02-08 18:31 ` Eric Dumazet
2021-02-09 2:05 ` Taehee Yoo
2021-02-09 2:18 ` David Ahern
2021-02-09 2:22 ` Taehee Yoo
2021-02-09 2:56 ` Jakub Kicinski
2021-02-09 3:33 ` Taehee Yoo
2021-02-09 1:55 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102090915.mQU3zE2r-lkp@intel.com \
--to=lkp@intel.com \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).