From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA28FC433E0 for ; Tue, 9 Feb 2021 11:19:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B59E64E6B for ; Tue, 9 Feb 2021 11:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230398AbhBILSx (ORCPT ); Tue, 9 Feb 2021 06:18:53 -0500 Received: from mail.baikalelectronics.com ([87.245.175.226]:59830 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbhBILQ4 (ORCPT ); Tue, 9 Feb 2021 06:16:56 -0500 Date: Tue, 9 Feb 2021 14:16:09 +0300 From: Serge Semin To: Andrew Lunn CC: Serge Semin , Rob Herring , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Alexey Malahov , Pavel Parkhomenko , Vyacheslav Mitrofanov , Maxime Coquelin , , , , , Subject: Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support Message-ID: <20210209111609.tjxoqr6stkcf22jy@mobilestation> References: <20210208140820.10410-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 08, 2021 at 08:36:33PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:08:04PM +0300, Serge Semin wrote: > > Hi Serge > > I suggest you split this patchset up. This uses the generic GPIO > framework, which is great. But that also means you should be Cc: the > GPIO subsystem maintainers and list. But you don't want to spam them > with all the preparation work, which has little to do with the GPIO > code. > > So please split the actual GPIO driver and DT binding patches from the > rest. netdev can review the preparation work, with a comment in the > 0/X patch about what the big picture is, and then afterwards review > the GPIO patchset with a wider audience. > > And as Jakub pointed out, nobody is going to review 60 patches all at > once. Please submit one series at a time, get it merged, and then > move onto the next. Hello Andrew Right, with all that preparation work I've forgotten to Cc the GPIO-subsystem maintainers. Thanks for noticing this. Regarding the 60-patches. Please see my response to Jakub' post in the first series. To cut it short let's start working with that patchset: Link: https://lore.kernel.org/netdev/20210208135609.7685-1-Sergey.Semin@baikalelectronics.ru/ I'll rebase and resubmit the rest of the work when the time comes. Regarding splitting the series up. I don't see a problem in just sending the cover-letter patch and actual GPIO-related patches to the GPIO-maintainers with no need to have them added to Cc in the rest of the series. That's a normal practice. Splitting is not really required. But since I have to split the very first patchset anyway. I'll split this one up too, when it comes to have this part of changes reviewed. -Sergey > > Andrew