From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A05D4C433E6 for ; Fri, 12 Feb 2021 14:36:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AE7564DD9 for ; Fri, 12 Feb 2021 14:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbhBLOgO (ORCPT ); Fri, 12 Feb 2021 09:36:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231317AbhBLOfh (ORCPT ); Fri, 12 Feb 2021 09:35:37 -0500 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BA33C06178C for ; Fri, 12 Feb 2021 06:34:10 -0800 (PST) Received: by mail-il1-x133.google.com with SMTP id z18so8298418ile.9 for ; Fri, 12 Feb 2021 06:34:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NzF0Z/WT0Iww7BykRJiaFbQQuxI8ckW46WWDqtEbJzw=; b=gCEH7M3Lg1UCLH9mgtLugfV1AZ8Bjq88W4HRCIwDOaZnqZ3hK0UcGrSxVVJlFfv9Z0 IMAlAsZ8dqCp3Wh+kW4tAW/ycPdrMgmSV9uahXitKHYMqHDUD1MTABk0ieJcPxSdg0AU GXVjpvLX6aJOGOHy3HbHf4Ef+1XLcFepKaDjmMaviJpL6wQ+PQq0OW8ZYu/IIiO9o6ff /zHCgG4XhbcCmCT7QgAyHZvrGGX4SHEGQfDT/BTIVwu3gJ6ojNU8Kb/Tt13lWE+co6Ba Acxfv6V8DU8x8VsQhNW1oP1vWxLkuZ0/wbj9QTAilzxsGRA+JQr4/4Tphf1cC73ZG7Qw G/3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NzF0Z/WT0Iww7BykRJiaFbQQuxI8ckW46WWDqtEbJzw=; b=TwylMZQxPrgsncY3YZJZ+6gRNKUm1riqY3ABoSD0HIEaMm+e+QYPVXPk7qXlUmaaDC hYmGzdjQKpXes7njXD63fehY9BeQ3C+1rLorX4n6Wb/BASq2r3dJH58AeBL6aHVOY9dU 09ooHxWV7hbePqUnCU3CqLmhUjXqOh3EvFzNsscTchtr4vmNjQD1elK/qq78QBAJRXJq DAkJPPkH3vwMUmAdKLEokiSl9qBlecyMcuDYZErWYCsXkPg8gNyTLr/rJMyunACwLrzb qHCQdulk/5AVL3Y9Jv7BKS8lpu4JfFQJWfWtmc7nvJU5bHufkp1I94jBr7tPQ1p2mHbE KBHA== X-Gm-Message-State: AOAM531kN6RybtSowULLNQyL6GOTEgPbV4DTSiM4xMybmOFUsFstEY/c 1SmXq1/xVbhQeDSCmS8SAmPSgA== X-Google-Smtp-Source: ABdhPJxfb1MNCQ63PaMi+oCBa/VI1Q7+9zNnsboxH0kj7yNd9BrbUsuhBZfcs6rozQxfLnex498dLw== X-Received: by 2002:a92:cd8a:: with SMTP id r10mr2531644ilb.110.1613140449627; Fri, 12 Feb 2021 06:34:09 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id j12sm4387878ila.75.2021.02.12.06.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 06:34:09 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 net-next 3/5] net: ipa: fix register write command validation Date: Fri, 12 Feb 2021 08:34:00 -0600 Message-Id: <20210212143402.2691-4-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210212143402.2691-1-elder@linaro.org> References: <20210212143402.2691-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In ipa_cmd_register_write_valid() we verify that values we will supply to a REGISTER_WRITE IPA immediate command will fit in the fields that need to hold them. This patch fixes some issues in that function and ipa_cmd_register_write_offset_valid(). The dev_err() call in ipa_cmd_register_write_offset_valid() has some printf format errors: - The name of the register (corresponding to the string format specifier) was not supplied. - The IPA base offset and offset need to be supplied separately to match the other format specifiers. Also make the ~0 constant used there to compute the maximum supported offset value explicitly unsigned. There are two other issues in ipa_cmd_register_write_valid(): - There's no need to check the hash flush register for platforms (like IPA v4.2) that do not support hashed tables - The highest possible endpoint number, whose status register offset is computed, is COUNT - 1, not COUNT. Fix these problems, and add some additional commentary. Signed-off-by: Alex Elder --- v2: - Update copyright. drivers/net/ipa/ipa_cmd.c | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/drivers/net/ipa/ipa_cmd.c b/drivers/net/ipa/ipa_cmd.c index 97b50fee60089..fd8bf6468d313 100644 --- a/drivers/net/ipa/ipa_cmd.c +++ b/drivers/net/ipa/ipa_cmd.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (c) 2012-2018, The Linux Foundation. All rights reserved. - * Copyright (C) 2019-2020 Linaro Ltd. + * Copyright (C) 2019-2021 Linaro Ltd. */ #include @@ -244,11 +244,15 @@ static bool ipa_cmd_register_write_offset_valid(struct ipa *ipa, if (ipa->version != IPA_VERSION_3_5_1) bit_count += hweight32(REGISTER_WRITE_FLAGS_OFFSET_HIGH_FMASK); BUILD_BUG_ON(bit_count > 32); - offset_max = ~0 >> (32 - bit_count); + offset_max = ~0U >> (32 - bit_count); + /* Make sure the offset can be represented by the field(s) + * that holds it. Also make sure the offset is not outside + * the overall IPA memory range. + */ if (offset > offset_max || ipa->mem_offset > offset_max - offset) { dev_err(dev, "%s offset too large 0x%04x + 0x%04x > 0x%04x)\n", - ipa->mem_offset + offset, offset_max); + name, ipa->mem_offset, offset, offset_max); return false; } @@ -261,12 +265,24 @@ static bool ipa_cmd_register_write_valid(struct ipa *ipa) const char *name; u32 offset; - offset = ipa_reg_filt_rout_hash_flush_offset(ipa->version); - name = "filter/route hash flush"; - if (!ipa_cmd_register_write_offset_valid(ipa, name, offset)) - return false; + /* If hashed tables are supported, ensure the hash flush register + * offset will fit in a register write IPA immediate command. + */ + if (ipa->version != IPA_VERSION_4_2) { + offset = ipa_reg_filt_rout_hash_flush_offset(ipa->version); + name = "filter/route hash flush"; + if (!ipa_cmd_register_write_offset_valid(ipa, name, offset)) + return false; + } - offset = IPA_REG_ENDP_STATUS_N_OFFSET(IPA_ENDPOINT_COUNT); + /* Each endpoint can have a status endpoint associated with it, + * and this is recorded in an endpoint register. If the modem + * crashes, we reset the status endpoint for all modem endpoints + * using a register write IPA immediate command. Make sure the + * worst case (highest endpoint number) offset of that endpoint + * fits in the register write command field(s) that must hold it. + */ + offset = IPA_REG_ENDP_STATUS_N_OFFSET(IPA_ENDPOINT_COUNT - 1); name = "maximal endpoint status"; if (!ipa_cmd_register_write_offset_valid(ipa, name, offset)) return false; -- 2.20.1