From: Vladimir Oltean <olteanv@gmail.com>
To: Nikolay Aleksandrov <nikolay@nvidia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Woojung Huh <woojung.huh@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Hauke Mehrtens <hauke@hauke-m.de>, Jiri Pirko <jiri@resnulli.us>,
Ivan Vecera <ivecera@redhat.com>, Roopa Prabhu <roopa@nvidia.com>,
DENG Qingfang <dqfext@gmail.com>,
Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net-next 3/5] net: bridge: propagate extack through switchdev_port_attr_set
Date: Sun, 14 Feb 2021 18:39:36 +0200 [thread overview]
Message-ID: <20210214163936.ut33qwe7opr4rhfk@skbuf> (raw)
In-Reply-To: <74e91dbb-7584-1201-da88-77fbf93e26ab@nvidia.com>
Hi Nikolay,
On Sun, Feb 14, 2021 at 12:45:11PM +0200, Nikolay Aleksandrov wrote:
> On 13/02/2021 22:43, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@nxp.com>
> >
> > The benefit is the ability to propagate errors from switchdev drivers
> > for the SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING and
> > SWITCHDEV_ATTR_ID_BRIDGE_VLAN_PROTOCOL attributes.
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
> > include/net/switchdev.h | 3 ++-
> > net/bridge/br_mrp_switchdev.c | 4 ++--
> > net/bridge/br_multicast.c | 6 +++---
> > net/bridge/br_netlink.c | 2 +-
> > net/bridge/br_private.h | 3 ++-
> > net/bridge/br_stp.c | 4 ++--
> > net/bridge/br_switchdev.c | 6 ++++--
> > net/bridge/br_vlan.c | 13 +++++++------
> > net/switchdev/switchdev.c | 19 ++++++++++++-------
> > 9 files changed, 35 insertions(+), 25 deletions(-)
> >
>
> You have to update the !CONFIG_NET_SWITCHDEV switchdev_port_attr_set() stub as well.
Thanks for pointing this out, you are right, the build fails.
What is really curious is that I had this issue on my radar but I forgot
to address it nonetheless.
I will take a step back and defer this series for after the break.
next prev parent reply other threads:[~2021-02-14 16:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 20:43 [PATCH net-next 0/5] Propagate extack for switchdev VLANs from DSA Vladimir Oltean
2021-02-13 20:43 ` [PATCH net-next 1/5] net: bridge: remove __br_vlan_filter_toggle Vladimir Oltean
2021-02-14 1:04 ` Florian Fainelli
2021-02-14 10:20 ` Nikolay Aleksandrov
2021-02-13 20:43 ` [PATCH net-next 2/5] net: bridge: propagate extack through store_bridge_parm Vladimir Oltean
2021-02-14 1:06 ` Florian Fainelli
2021-02-14 10:43 ` Nikolay Aleksandrov
2021-02-13 20:43 ` [PATCH net-next 3/5] net: bridge: propagate extack through switchdev_port_attr_set Vladimir Oltean
2021-02-14 1:14 ` Florian Fainelli
2021-02-14 10:45 ` Nikolay Aleksandrov
2021-02-14 16:39 ` Vladimir Oltean [this message]
2021-02-13 20:43 ` [PATCH net-next 4/5] net: dsa: propagate extack to .port_vlan_add Vladimir Oltean
2021-02-14 1:16 ` Florian Fainelli
2021-02-13 20:43 ` [PATCH net-next 5/5] net: dsa: propagate extack to .port_vlan_filtering Vladimir Oltean
2021-02-14 1:17 ` Florian Fainelli
2021-02-15 20:40 ` [PATCH net-next 0/5] Propagate extack for switchdev VLANs from DSA patchwork-bot+netdevbpf
2021-02-15 20:49 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210214163936.ut33qwe7opr4rhfk@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=idosch@idosch.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).