From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84084C433DB for ; Wed, 17 Feb 2021 17:15:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B2EF64DEC for ; Wed, 17 Feb 2021 17:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234390AbhBQRPS (ORCPT ); Wed, 17 Feb 2021 12:15:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30293 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234352AbhBQRPO (ORCPT ); Wed, 17 Feb 2021 12:15:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613582025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QiquG9IOiLb2ArxThqBsSmOSv1VEYLQ2aODCK5RKfjM=; b=YFL91b4aHCnHJt1bMmguFZITJU5YUPxL/3yQ7pbSG9qBT6+Yxalvg3juAde/tzdCyMQ1Sk PnAbLKkTSp2057sZG7OOmHEXXtWr9VBxNO0Dqm2uqmpga2QluSSy55tspnD+qalvcg+yJ1 2aMoFpFQ5wrGWIBQrTy4LJajU+a+qAA= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-ptA4gRW0OvqZ-beGO8cUCQ-1; Wed, 17 Feb 2021 12:13:43 -0500 X-MC-Unique: ptA4gRW0OvqZ-beGO8cUCQ-1 Received: by mail-ej1-f70.google.com with SMTP id er8so8858438ejc.13 for ; Wed, 17 Feb 2021 09:13:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QiquG9IOiLb2ArxThqBsSmOSv1VEYLQ2aODCK5RKfjM=; b=ukkUZEve3QhoqivF6176e8tUGUoMwFODF+iXe0Zup628sh3nbxMe1nhQrdXBJ3vvbg cjdyCgeZwv0pa+OCnpsBExI6BCvtbuTGMYRxluFRT5rg5nVL53/HAGC4NT5LeNLD7rSw vWZ7bVvk1gXmCpYOV/7s2WbLy/BNsZ1+e4hR5G50CVnCMYxRWiT9yLcVNWZkKfO1fCYA pp+B2Xg+ck1moaqxq1Oz+9d8xBwCQhOiQpVE2P1uPB+lcDUTC7DefUsFXmsxV4p+h/3r flsSMge3kyovtvtX6z7/E9ylbbRKqMdgAWoiHjgP+VPKkHaZZqQC3JRn8uxkuPWTvIA+ mONQ== X-Gm-Message-State: AOAM530EE696wDLZ5CcoYj27gdf9rwMe7U2ppA4Rze5M30Xq/Hpdhsnh gJpXUQRFdkfRzztQj5Gsx10vAhwQrqa3ta5giZG0hpdP8P9LhCrtnFH6ghioVpmlnAxBvbW3sQy SqFUW+E5VH8vTdjn0 X-Received: by 2002:a05:6402:1484:: with SMTP id e4mr27937282edv.104.1613582022713; Wed, 17 Feb 2021 09:13:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwuvd1ltECKJmOuiIgpNkSWnIT6BYItP6BB7mgr9PrMcDvlJLCU0gU86eEIIRUXY3AbAs2Oww== X-Received: by 2002:a05:6402:1484:: with SMTP id e4mr27937261edv.104.1613582022551; Wed, 17 Feb 2021 09:13:42 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id f13sm1302362ejf.42.2021.02.17.09.13.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 09:13:41 -0800 (PST) Date: Wed, 17 Feb 2021 12:13:37 -0500 From: "Michael S. Tsirkin" To: Eli Cohen Cc: jasowang@redhat.com, si-wei.liu@oracle.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Parav Pandit Subject: Re: [PATCH 2/2 v1] vdpa/mlx5: Enable user to add/delete vdpa device Message-ID: <20210217121315-mutt-send-email-mst@kernel.org> References: <20210217113136.10215-1-elic@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210217113136.10215-1-elic@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 17, 2021 at 01:31:36PM +0200, Eli Cohen wrote: > Allow to control vdpa device creation and destruction using the vdpa > management tool. > > Examples: > 1. List the management devices > $ vdpa mgmtdev show > pci/0000:3b:00.1: > supported_classes net > > 2. Create vdpa instance > $ vdpa dev add mgmtdev pci/0000:3b:00.1 name vdpa0 > > 3. Show vdpa devices > $ vdpa dev show > vdpa0: type network mgmtdev pci/0000:3b:00.1 vendor_id 5555 max_vqs 16 \ > max_vq_size 256 > > Signed-off-by: Eli Cohen > Reviewed-by: Parav Pandit where's the rest of the patchset though? I only got 2/2 ... confused. > --- > v0->v1: > set mgtdev->ndev NULL on dev delete > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 79 +++++++++++++++++++++++++++---- > 1 file changed, 70 insertions(+), 9 deletions(-) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index a51b0f86afe2..08fb481ddc4f 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -1974,23 +1974,32 @@ static void init_mvqs(struct mlx5_vdpa_net *ndev) > } > } > > -static int mlx5v_probe(struct auxiliary_device *adev, > - const struct auxiliary_device_id *id) > +struct mlx5_vdpa_mgmtdev { > + struct vdpa_mgmt_dev mgtdev; > + struct mlx5_adev *madev; > + struct mlx5_vdpa_net *ndev; > +}; > + > +static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_mdev, const char *name) > { > - struct mlx5_adev *madev = container_of(adev, struct mlx5_adev, adev); > - struct mlx5_core_dev *mdev = madev->mdev; > + struct mlx5_vdpa_mgmtdev *mgtdev = container_of(v_mdev, struct mlx5_vdpa_mgmtdev, mgtdev); > struct virtio_net_config *config; > struct mlx5_vdpa_dev *mvdev; > struct mlx5_vdpa_net *ndev; > + struct mlx5_core_dev *mdev; > u32 max_vqs; > int err; > > + if (mgtdev->ndev) > + return -ENOSPC; > + > + mdev = mgtdev->madev->mdev; > /* we save one virtqueue for control virtqueue should we require it */ > max_vqs = MLX5_CAP_DEV_VDPA_EMULATION(mdev, max_num_virtio_queues); > max_vqs = min_t(u32, max_vqs, MLX5_MAX_SUPPORTED_VQS); > > ndev = vdpa_alloc_device(struct mlx5_vdpa_net, mvdev.vdev, mdev->device, &mlx5_vdpa_ops, > - 2 * mlx5_vdpa_max_qps(max_vqs), NULL); > + 2 * mlx5_vdpa_max_qps(max_vqs), name); > if (IS_ERR(ndev)) > return PTR_ERR(ndev); > > @@ -2018,11 +2027,12 @@ static int mlx5v_probe(struct auxiliary_device *adev, > if (err) > goto err_res; > > - err = vdpa_register_device(&mvdev->vdev); > + mvdev->vdev.mdev = &mgtdev->mgtdev; > + err = _vdpa_register_device(&mvdev->vdev); > if (err) > goto err_reg; > > - dev_set_drvdata(&adev->dev, ndev); > + mgtdev->ndev = ndev; > return 0; > > err_reg: > @@ -2035,11 +2045,62 @@ static int mlx5v_probe(struct auxiliary_device *adev, > return err; > } > > +static void mlx5_vdpa_dev_del(struct vdpa_mgmt_dev *v_mdev, struct vdpa_device *dev) > +{ > + struct mlx5_vdpa_mgmtdev *mgtdev = container_of(v_mdev, struct mlx5_vdpa_mgmtdev, mgtdev); > + > + _vdpa_unregister_device(dev); > + mgtdev->ndev = NULL; > +} > + > +static const struct vdpa_mgmtdev_ops mdev_ops = { > + .dev_add = mlx5_vdpa_dev_add, > + .dev_del = mlx5_vdpa_dev_del, > +}; > + > +static struct virtio_device_id id_table[] = { > + { VIRTIO_ID_NET, VIRTIO_DEV_ANY_ID }, > + { 0 }, > +}; > + > +static int mlx5v_probe(struct auxiliary_device *adev, > + const struct auxiliary_device_id *id) > + > +{ > + struct mlx5_adev *madev = container_of(adev, struct mlx5_adev, adev); > + struct mlx5_core_dev *mdev = madev->mdev; > + struct mlx5_vdpa_mgmtdev *mgtdev; > + int err; > + > + mgtdev = kzalloc(sizeof(*mgtdev), GFP_KERNEL); > + if (!mgtdev) > + return -ENOMEM; > + > + mgtdev->mgtdev.ops = &mdev_ops; > + mgtdev->mgtdev.device = mdev->device; > + mgtdev->mgtdev.id_table = id_table; > + mgtdev->madev = madev; > + > + err = vdpa_mgmtdev_register(&mgtdev->mgtdev); > + if (err) > + goto reg_err; > + > + dev_set_drvdata(&adev->dev, mgtdev); > + > + return 0; > + > +reg_err: > + kfree(mdev); > + return err; > +} > + > static void mlx5v_remove(struct auxiliary_device *adev) > { > - struct mlx5_vdpa_dev *mvdev = dev_get_drvdata(&adev->dev); > + struct mlx5_vdpa_mgmtdev *mgtdev; > > - vdpa_unregister_device(&mvdev->vdev); > + mgtdev = dev_get_drvdata(&adev->dev); > + vdpa_mgmtdev_unregister(&mgtdev->mgtdev); > + kfree(mgtdev); > } > > static const struct auxiliary_device_id mlx5v_id_table[] = { > -- > 2.29.2