From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables
Date: Thu, 18 Feb 2021 09:13:24 +0100 [thread overview]
Message-ID: <20210218081324.GA68220@wp.pl> (raw)
In-Reply-To: <1613632814-37897-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Thu, Feb 18, 2021 at 03:20:14PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
> || A && B is equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> index 28675a4..52db532 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> @@ -2593,8 +2593,7 @@ struct il_mod_params il4965_mod_params = {
> */
> if (ret != IL_INVALID_STATION &&
> (!(il->stations[ret].used & IL_STA_UCODE_ACTIVE) ||
> - ((il->stations[ret].used & IL_STA_UCODE_ACTIVE) &&
> - (il->stations[ret].used & IL_STA_UCODE_INPROGRESS)))) {
> + (il->stations[ret].used & IL_STA_UCODE_INPROGRESS))) {
> IL_ERR("Requested station info for sta %d before ready.\n",
> ret);
> ret = IL_INVALID_STATION;
This patch was already applied to wireless-drivers-next.
Stanislaw
next prev parent reply other threads:[~2021-02-18 8:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 7:20 [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables Jiapeng Chong
2021-02-18 8:13 ` Stanislaw Gruszka [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-04 8:00 Jiapeng Chong
2021-02-04 9:14 ` Stanislaw Gruszka
2021-02-08 11:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218081324.GA68220@wp.pl \
--to=stf_xl@wp.pl \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).