netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: netdev@vger.kernel.org, grundler@chromium.org, andrew@lunn.ch,
	davem@devemloft.org, hayeswang@realtek.com,
	Roland Dreier <roland@kernel.org>
Subject: Re: [PATCHv3 2/3] usbnet: add method for reporting speed without MDIO
Date: Thu, 18 Feb 2021 11:06:45 -0800	[thread overview]
Message-ID: <20210218110645.1375cfbf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210218102038.2996-3-oneukum@suse.com>

On Thu, 18 Feb 2021 11:20:37 +0100 Oliver Neukum wrote:
> The old method for reporting network speed upwards
> assumed that a device uses MDIO and uses the generic phy
> functions based on that.
> Add a a primitive internal version not making the assumption
> reporting back directly what the status operations record.
> 
> v2: rebased on upstream
> v3: changed names and made clear which units are used
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Tested-by: Roland Dreier <roland@kernel.org>

ERROR: trailing whitespace
#48: FILE: drivers/net/usb/usbnet.c:1690:
+^Idev->tx_speed = SPEED_UNSET; $

  reply	other threads:[~2021-02-18 19:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 10:20 [PATCHv3 0/3]usbnet: speed reporting for devices without MDIO Oliver Neukum
2021-02-18 10:20 ` [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings Oliver Neukum
2021-02-18 19:06   ` Jakub Kicinski
2021-02-18 19:31   ` Grant Grundler
2021-02-18 19:50     ` Andrew Lunn
2021-02-19  7:12       ` Grant Grundler
2021-02-18 10:20 ` [PATCHv3 2/3] usbnet: add method for reporting speed without MDIO Oliver Neukum
2021-02-18 19:06   ` Jakub Kicinski [this message]
2021-02-18 10:20 ` [PATCHv3 3/3] CDC-NCM: record speed in status method Oliver Neukum
2021-02-19  7:30   ` Grant Grundler
2021-02-22 10:14     ` Oliver Neukum
2021-02-24  5:24       ` Grant Grundler
2021-03-20  5:24       ` Grant Grundler
2021-02-19  7:43   ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210218110645.1375cfbf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@devemloft.org \
    --cc=grundler@chromium.org \
    --cc=hayeswang@realtek.com \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=roland@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).