From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71230C433DB for ; Sun, 21 Feb 2021 21:54:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29F2D60234 for ; Sun, 21 Feb 2021 21:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbhBUVxl (ORCPT ); Sun, 21 Feb 2021 16:53:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30212 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbhBUVxi (ORCPT ); Sun, 21 Feb 2021 16:53:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613944331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U4JsN97Zzk+H8tb+mmssPj3kHXJxDnBczVQV8wHqk+k=; b=awBSl4/lEAHkkGzWBIozLn3f6bD4vHUvn19yTKxJ/ZT9vdkMVXwvhmVx8IaipOGc0g2K1l CLvXqL3IBydw9W1G9JK1Cz1JhVDBLudhlv33JgwPXcUiOfn93K5dD1gM93II2XqscMH/21 9ePV4NUUbQEdEgfYYNMPM66+MbH1r7c= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-9-yNULV_2lPYuiqUTPJUkrVg-1; Sun, 21 Feb 2021 16:52:09 -0500 X-MC-Unique: yNULV_2lPYuiqUTPJUkrVg-1 Received: by mail-ej1-f72.google.com with SMTP id p15so3327370ejq.22 for ; Sun, 21 Feb 2021 13:52:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U4JsN97Zzk+H8tb+mmssPj3kHXJxDnBczVQV8wHqk+k=; b=AojwVE/MjngB0TVC2f/vNy/kQXxWPL5XSYe7a9VLGtxSZeNJ5vNBZG00pR8a49KMu0 pkD+yzZryQJPo6nwdZuVBjHgi/fmefi078rneC1U4W7B9eU6iGihZycXWCwAsoL1ZrMu 57RgGB7lBSBlqxC7ISmS+GY0JmZT6fKsItd7i3RLCSnP0yiCK5JVBnNrIEF3xkL4jS2J 11PB42p+zQYoCzaC3n2RJH8gquLYPuqAZIWL43CpQTZUZ2iVf9PcKqSni1A5/yFWxmgx 4t08gPK1urGccEJVMjbWqP9THIuFTwM7NihiERkoVISdi2EXwZouJsf5zmiQKufTHlOG 3Ehw== X-Gm-Message-State: AOAM532cW7Htkf5PCpt8xgtOTx/sHz01dnyNUTyjQn5JXrlFT1pvKroq k8/Jytg5Y0GIJfeyF9t8eBe1a9AKGnlqlpRrov4empAmOz6stnPJU7wZjZ+qugsX6B1nEoldUuS VC5S/8jWnUuykbVFi X-Received: by 2002:a50:d302:: with SMTP id g2mr19664804edh.75.1613944328566; Sun, 21 Feb 2021 13:52:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzgYIXSiqbazhwzI8TFh//3IRP1DzyO5yog4TY97wdwAVbNltx2njk4e91QiFVuiQ2EuP71Eg== X-Received: by 2002:a50:d302:: with SMTP id g2mr19664791edh.75.1613944328428; Sun, 21 Feb 2021 13:52:08 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id by8sm6554697edb.95.2021.02.21.13.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 13:52:07 -0800 (PST) Date: Sun, 21 Feb 2021 16:52:05 -0500 From: "Michael S. Tsirkin" To: Eli Cohen Cc: Si-Wei Liu , jasowang@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero Message-ID: <20210221165047-mutt-send-email-mst@kernel.org> References: <1613735698-3328-1-git-send-email-si-wei.liu@oracle.com> <20210221144437.GA82010@mtl-vdi-166.wap.labs.mlnx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210221144437.GA82010@mtl-vdi-166.wap.labs.mlnx> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 21, 2021 at 04:44:37PM +0200, Eli Cohen wrote: > On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > > for legacy") made an exception for legacy guests to reset > > features to 0, when config space is accessed before features > > are set. We should relieve the verify_min_features() check > > and allow features reset to 0 for this case. > > > > It's worth noting that not just legacy guests could access > > config space before features are set. For instance, when > > feature VIRTIO_NET_F_MTU is advertised some modern driver > > will try to access and validate the MTU present in the config > > space before virtio features are set. Rejecting reset to 0 > > prematurely causes correct MTU and link status unable to load > > for the very first config space access, rendering issues like > > guest showing inaccurate MTU value, or failure to reject > > out-of-range MTU. > > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") > > Signed-off-by: Si-Wei Liu > > --- > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 15 +-------------- > > 1 file changed, 1 insertion(+), 14 deletions(-) > > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > index 7c1f789..540dd67 100644 > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > @@ -1490,14 +1490,6 @@ static u64 mlx5_vdpa_get_features(struct vdpa_device *vdev) > > return mvdev->mlx_features; > > } > > > > -static int verify_min_features(struct mlx5_vdpa_dev *mvdev, u64 features) > > -{ > > - if (!(features & BIT_ULL(VIRTIO_F_ACCESS_PLATFORM))) > > - return -EOPNOTSUPP; > > - > > - return 0; > > -} > > - > > But what if VIRTIO_F_ACCESS_PLATFORM is not offerred? This does not > support such cases. Did you mean "catch such cases" rather than "support"? > Maybe we should call verify_min_features() from mlx5_vdpa_set_status() > just before attempting to call setup_driver(). > > > static int setup_virtqueues(struct mlx5_vdpa_net *ndev) > > { > > int err; > > @@ -1558,18 +1550,13 @@ static int mlx5_vdpa_set_features(struct vdpa_device *vdev, u64 features) > > { > > struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev); > > struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev); > > - int err; > > > > print_features(mvdev, features, true); > > > > - err = verify_min_features(mvdev, features); > > - if (err) > > - return err; > > - > > ndev->mvdev.actual_features = features & ndev->mvdev.mlx_features; > > ndev->config.mtu = cpu_to_mlx5vdpa16(mvdev, ndev->mtu); > > ndev->config.status |= cpu_to_mlx5vdpa16(mvdev, VIRTIO_NET_S_LINK_UP); > > - return err; > > + return 0; > > } > > > > static void mlx5_vdpa_set_config_cb(struct vdpa_device *vdev, struct vdpa_callback *cb) > > -- > > 1.8.3.1 > >