netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Christian Melki <christian.melki@t2data.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081
Date: Mon, 22 Feb 2021 19:04:30 -0800	[thread overview]
Message-ID: <20210222190430.12ec4eda@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <5eb8b25e-f646-ed3d-8572-9b6ef318ae9e@t2data.com>

On Thu, 18 Feb 2021 22:09:32 +0100 Christian Melki wrote:
> Following a similar reinstate for the KSZ9031.
> 
> Older kernels would use the genphy_soft_reset if the PHY did not 
> implement a .soft_reset.
> 
> Bluntly removing that default may expose a lot of situations where 
> various PHYs/board implementations won't recover on various changes.
> Like with implementation during a 4.9.x to 5.4.x LTS transition.
> I think it's a good thing to remove unwanted soft resets but wonder if 
> it did open a can of worms?
> 
> Atleast this fixes one iMX6 FEC/RMII/8081 combo.
> 
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Signed-off-by: Christian Melki <christian.melki@t2data.com>

Does not apply to net/master:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/

Please rebase and resend.

Please make sure you CC maintainers and other relevant developers 
(you can use ./scripts/get_maintainers.pl $path_to_patch to find them).

      reply	other threads:[~2021-02-23  3:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 21:09 [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081 Christian Melki
2021-02-23  3:04 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210222190430.12ec4eda@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=christian.melki@t2data.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).