Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081
@ 2021-02-18 21:09 Christian Melki
  2021-02-23  3:04 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Melki @ 2021-02-18 21:09 UTC (permalink / raw)
  To: netdev

Following a similar reinstate for the KSZ9031.

Older kernels would use the genphy_soft_reset if the PHY did not 
implement a .soft_reset.

Bluntly removing that default may expose a lot of situations where 
various PHYs/board implementations won't recover on various changes.
Like with implementation during a 4.9.x to 5.4.x LTS transition.
I think it's a good thing to remove unwanted soft resets but wonder if 
it did open a can of worms?

Atleast this fixes one iMX6 FEC/RMII/8081 combo.

Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
Signed-off-by: Christian Melki <christian.melki@t2data.com>
---
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 54e0d75203da..57f8021b70af 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1295,6 +1295,7 @@ static struct phy_driver ksphy_driver[] = {
  	.driver_data	= &ksz8081_type,
  	.probe		= kszphy_probe,
  	.config_init	= ksz8081_config_init,
+	.soft_reset	= genphy_soft_reset,
  	.config_intr	= kszphy_config_intr,
  	.handle_interrupt = kszphy_handle_interrupt,
  	.get_sset_count = kszphy_get_sset_count,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081
  2021-02-18 21:09 [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081 Christian Melki
@ 2021-02-23  3:04 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-02-23  3:04 UTC (permalink / raw)
  To: Christian Melki; +Cc: netdev

On Thu, 18 Feb 2021 22:09:32 +0100 Christian Melki wrote:
> Following a similar reinstate for the KSZ9031.
> 
> Older kernels would use the genphy_soft_reset if the PHY did not 
> implement a .soft_reset.
> 
> Bluntly removing that default may expose a lot of situations where 
> various PHYs/board implementations won't recover on various changes.
> Like with implementation during a 4.9.x to 5.4.x LTS transition.
> I think it's a good thing to remove unwanted soft resets but wonder if 
> it did open a can of worms?
> 
> Atleast this fixes one iMX6 FEC/RMII/8081 combo.
> 
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Signed-off-by: Christian Melki <christian.melki@t2data.com>

Does not apply to net/master:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/

Please rebase and resend.

Please make sure you CC maintainers and other relevant developers 
(you can use ./scripts/get_maintainers.pl $path_to_patch to find them).

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 21:09 [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081 Christian Melki
2021-02-23  3:04 ` Jakub Kicinski

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git