Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] netdevsim: fib: remove unneeded semicolon
@ 2021-02-23  2:28 Jiapeng Chong
  2021-02-23 11:07 ` Ido Schimmel
  2021-02-23 16:35 ` Jakub Kicinski
  0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2021-02-23  2:28 UTC (permalink / raw)
  To: kuba; +Cc: davem, netdev, linux-kernel, Jiapeng Chong

Fix the following coccicheck warnings:

./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
Changes in v2:
  - Remove the braces.

 drivers/net/netdevsim/fib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
index 46fb414..3acfe27 100644
--- a/drivers/net/netdevsim/fib.c
+++ b/drivers/net/netdevsim/fib.c
@@ -559,9 +559,8 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
 	return fib6_rt;
 
 err_fib6_rt_nh_del:
-	for (i--; i >= 0; i--) {
+	for (i--; i >= 0; i--)
 		nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
-	};
 	nsim_fib_rt_fini(&fib6_rt->common);
 	kfree(fib6_rt);
 	return ERR_PTR(err);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] netdevsim: fib: remove unneeded semicolon
  2021-02-23  2:28 [PATCH v2] netdevsim: fib: remove unneeded semicolon Jiapeng Chong
@ 2021-02-23 11:07 ` Ido Schimmel
  2021-02-23 16:35 ` Jakub Kicinski
  1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2021-02-23 11:07 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: kuba, davem, netdev, linux-kernel

On Tue, Feb 23, 2021 at 10:28:46AM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] netdevsim: fib: remove unneeded semicolon
  2021-02-23  2:28 [PATCH v2] netdevsim: fib: remove unneeded semicolon Jiapeng Chong
  2021-02-23 11:07 ` Ido Schimmel
@ 2021-02-23 16:35 ` Jakub Kicinski
  1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-02-23 16:35 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: davem, netdev, linux-kernel

On Tue, 23 Feb 2021 10:28:46 +0800 Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

# Form letter - net-next is closed

We have already sent the networking pull request for 5.12 
and therefore net-next is closed for new drivers, features, 
code refactoring and optimizations. We are currently accepting 
bug fixes only.

Please repost when net-next reopens after 5.12-rc1 is cut.

Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html

RFC patches sent for review only are obviously welcome at any time.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23  2:28 [PATCH v2] netdevsim: fib: remove unneeded semicolon Jiapeng Chong
2021-02-23 11:07 ` Ido Schimmel
2021-02-23 16:35 ` Jakub Kicinski

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git