netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: Nikolay Aleksandrov <nikolay@nvidia.com>,
	Roopa Prabhu <roopa@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: Timing of host-joined bridge multicast groups with switchdev
Date: Tue, 23 Feb 2021 20:02:36 +0200	[thread overview]
Message-ID: <20210223180236.e2ggiuxhr5aaayx5@skbuf> (raw)
In-Reply-To: <YDVBxrkYOtlmO1bn@shredder.lan>

On Tue, Feb 23, 2021 at 07:56:22PM +0200, Ido Schimmel wrote:
> For route offload you get a dump of all the existing routes when you
> register your notifier. It's a bit different with bridge because you
> don't care about existing bridges when you just initialize your driver.
>
> We had a similar issue with VXLAN because its FDB can be populated and
> only then attached to a bridge that you offload. Check
> vxlan_fdb_replay(). Probably need to introduce something similar for
> FDB/MDB entries.

So you would be in favor of a driver-voluntary 'pull' type of approach
at bridge join, instead of the bridge 'pushing' the addresses?

That's all fine, except when we'll have more than 3 switchdev drivers,
how do we expect to manage all this complexity duplicated in many places
in the kernel, instead of having it in a central place? Are there corner
cases I'm missing which make the 'push' approach impractical?

  reply	other threads:[~2021-02-23 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 17:37 Timing of host-joined bridge multicast groups with switchdev Vladimir Oltean
2021-02-23 17:56 ` Ido Schimmel
2021-02-23 18:02   ` Vladimir Oltean [this message]
2021-02-23 19:29     ` Ido Schimmel
2021-02-23 19:49       ` Vladimir Oltean
2021-02-23 20:07         ` Vladimir Oltean
2021-02-24  2:01         ` [PATCH] net: bridge: add a function that replays port and host-joined kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223180236.e2ggiuxhr5aaayx5@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@idosch.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=roopa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).