From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Sven Schuchmann <schuchmann@schleissheimer.de>
Cc: Dan Murphy <dmurphy@ti.com>, "kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: net: phy: ti: implement generic .handle_interrupt() callback
Date: Tue, 23 Feb 2021 18:18:13 +0000 [thread overview]
Message-ID: <20210223181812.ti3r5net4v6vcutt@skbuf> (raw)
In-Reply-To: <DB8P190MB0634C73B4363753F62FCE4B6D9809@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
On Tue, Feb 23, 2021 at 05:44:57PM +0000, Sven Schuchmann wrote:
> Hello all,
>
> I am working with the DP83TC811R but for now on the 5.10 kernel.
> I have seen this patch on the latest dev
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/phy/dp83tc811.c?h=v5.11&id=1d1ae3c6ca3ff49843d73852bb2a8153ce16f432
>
> I did not test it yet, but I wonder about one thing:
> What happens when there are 2 Flags set e.g.
> in INT_STAT1 and one in INT_STAT2?
> What I see from the code is that it would
> only read (and acknowledge) the first one and
> then quit out to trigger_machine.
>
> Any thoughts about this?
>
Hi Sven,
Indeed, I didn't take into consideration the fact that all the status
registers should be acknowledged since multiple interrupt sources could
be asserted. This could really break a system with an edge-triggered
interrupt.
I'll send out a fixup patch.
Thanks!
Ioana
prev parent reply other threads:[~2021-02-23 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 17:44 net: phy: ti: implement generic .handle_interrupt() callback Sven Schuchmann
2021-02-23 18:18 ` Ioana Ciornei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223181812.ti3r5net4v6vcutt@skbuf \
--to=ioana.ciornei@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=schuchmann@schleissheimer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).