From: Jakub Kicinski <kuba@kernel.org>
To: Sharath Chandra Vurukala <sharathv@codeaurora.org>
Cc: davem@davemloft.net, elder@kernel.org, cpratapa@codeaurora.org,
subashab@codeaurora.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload
Date: Wed, 24 Feb 2021 10:23:07 -0800 [thread overview]
Message-ID: <20210224102307.4a484568@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1614110571-11604-3-git-send-email-sharathv@codeaurora.org>
On Wed, 24 Feb 2021 01:32:50 +0530 Sharath Chandra Vurukala wrote:
> +/* MAP CSUM headers */
> +struct rmnet_map_v5_csum_header {
> +#if defined(__LITTLE_ENDIAN_BITFIELD)
> + u8 next_hdr:1;
> + u8 header_type:7;
> + u8 hw_reserved:7;
> + u8 csum_valid_required:1;
> +#elif defined(__BIG_ENDIAN_BITFIELD)
> + u8 header_type:7;
> + u8 next_hdr:1;
> + u8 csum_valid_required:1;
> + u8 hw_reserved:7;
> +#else
> +#error "Please fix <asm/byteorder.h>"
> +#endif
> + __be16 reserved;
> +} __aligned(1);
This seems to be your first contribution so let me spell it out.
In Linux when maintainers ask you to do something you are expected
to do it.
You can leave the existing bitfields for later, but don't add another.
next prev parent reply other threads:[~2021-02-24 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 20:02 [PATCH net-next v3 0/3] net: qualcomm: rmnet: Enable Mapv5 Sharath Chandra Vurukala
2021-02-23 20:02 ` [PATCH net-next v3 1/3] docs: networking: Add documentation for MAPv5 Sharath Chandra Vurukala
2021-02-23 20:02 ` [PATCH net-next v3 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload Sharath Chandra Vurukala
2021-02-24 18:23 ` Jakub Kicinski [this message]
2021-02-25 15:29 ` Alex Elder
2021-02-23 20:02 ` [PATCH net-next v3 3/3] net: ethernet: rmnet: Add support for Mapv5 uplink packet Sharath Chandra Vurukala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224102307.4a484568@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sharathv@codeaurora.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).