From: Vladimir Oltean <olteanv@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: sja1105: Remove unneeded cast in sja1105_crc32()
Date: Thu, 25 Feb 2021 00:43:58 +0200 [thread overview]
Message-ID: <20210224224358.pysql5pu23zt7mtb@skbuf> (raw)
In-Reply-To: <20210223112003.2223332-1-geert+renesas@glider.be>
On Tue, Feb 23, 2021 at 12:20:03PM +0100, Geert Uytterhoeven wrote:
> sja1105_unpack() takes a "const void *buf" as its first parameter, so
> there is no need to cast away the "const" of the "buf" variable before
> calling it.
>
> Drop the cast, as it prevents the compiler performing some checks.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
By the way, your email went straight to my spam box, I just found the
patch by mistake on patchwork.
Why is this message in spam?
It is in violation of Google's recommended email sender guidelines.
> Compile-tested only.
>
> BTW, sja1105_packing() and packing() are really bad APIs, as the input
> pointer parameters cannot be const due to the direction depending on
> "op". This means the compiler cannot do const checks. Worse, callers
> are required to cast away constness to prevent the compiler from
> issueing warnings. Please don't do this!
> ---
What const checks can the compiler not do?
Also, if you know of an existing kernel API which can replace packing(),
I'm all ears.
next prev parent reply other threads:[~2021-02-24 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 11:20 [PATCH] net: dsa: sja1105: Remove unneeded cast in sja1105_crc32() Geert Uytterhoeven
2021-02-24 22:43 ` Vladimir Oltean [this message]
2021-02-25 7:28 ` Geert Uytterhoeven
2021-02-25 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224224358.pysql5pu23zt7mtb@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).