From: Richard Cochran <richardcochran@gmail.com>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Fugang Duan <fugang.duan@nxp.com>
Subject: Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled
Date: Thu, 25 Feb 2021 09:14:54 -0800 [thread overview]
Message-ID: <20210225171454.GD17490@hoboy.vegasvil.org> (raw)
In-Reply-To: <CAEyMn7Yjug3S=2mRC8uA=_+Tdxe=m6G-ga1YuupLSx3mPqUoug@mail.gmail.com>
On Thu, Feb 25, 2021 at 03:05:32PM +0100, Heiko Thiery wrote:
> But the explanation why it is currently disabled that way can be found
> in the commit 91c0d987a9788dcc5fe26baafd73bf9242b68900.
Okay, without re-factoring the entire driver, I agree that the gettime
lock up aught to be fixed in a similar way. I missed the original
patch, but the diff fragment in this thread doesn't appear to take the
mutex as it should.
Thanks,
Richard
prev parent reply other threads:[~2021-02-25 17:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 6:56 [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled Heiko Thiery
2021-02-23 3:00 ` Jakub Kicinski
2021-02-23 8:00 ` Heiko Thiery
2021-02-23 14:27 ` Richard Cochran
2021-02-23 15:04 ` Heiko Thiery
2021-02-23 16:11 ` Richard Cochran
2021-02-25 13:49 ` Heiko Thiery
2021-02-25 14:05 ` Heiko Thiery
2021-02-25 17:14 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225171454.GD17490@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=heiko.thiery@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).