From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03138C433DB for ; Fri, 26 Feb 2021 21:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A726A64F13 for ; Fri, 26 Feb 2021 21:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230367AbhBZVHc (ORCPT ); Fri, 26 Feb 2021 16:07:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:35232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230040AbhBZVH1 (ORCPT ); Fri, 26 Feb 2021 16:07:27 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 78D4564EAF; Fri, 26 Feb 2021 21:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614373606; bh=dll3zwV+2fsgaVPWZQp38anBe34JTVJ6LJ1kb1y9oCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tTZwo7DopJ7h8hLaCuzLgarVUktQ7SYTz/lDZ52SXvmk8WL7p2SADNV0kNjadaHrS GDh0y7wYCBLp0FPGJp7J7w02oOky7poG5dAzFzEHMlfV0ZTc6Rl1D0wi4pY0zirqKq w2mCtrbziUpSk43BoXPrG8iVlHVntTeGuBw+rw1OtLMyCDfcHL7Y5c0L560VijWSfQ ozIgUgQKFDLrMVbI6YLm57hDEHrNriXhnRwbYF1W5649UxyDUCZR5zm8plokoPcT5L BVoqPFP2IuAY+twK7jn7YnDVKQNKbwGjJfmnAKm43DZDvbrfpD0WXMSW//RtnUAp89 5N1jAsGzUNaCA== Date: Fri, 26 Feb 2021 14:06:40 -0700 From: Nathan Chancellor To: Wei Yongjun Cc: Hulk Robot , Luca Coelho , Kalle Valo , Jakub Kicinski , Emmanuel Grumbach , Gil Adam , Mordechay Goodstein , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables Message-ID: <20210226210640.GA21320@MSI.localdomain> References: <20210223140039.1708534-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223140039.1708534-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 23, 2021 at 02:00:39PM +0000, Wei Yongjun wrote: > Make sure dmi_system_id tables are NULL terminated. > > Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG feature") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun We received a report about a crash in iwlwifi when compiled with LTO and this fix resolves it. Reviewed-by: Nathan Chancellor > --- > drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c > index 15e2773ce7e7..5ee64f7f3c85 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c > @@ -1083,6 +1083,7 @@ static const struct dmi_system_id dmi_ppag_approved_list[] = { > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTek COMPUTER INC."), > }, > }, > + {} > }; > > static int iwl_mvm_ppag_init(struct iwl_mvm *mvm) >