From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41709C433DB for ; Sun, 28 Feb 2021 21:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C22464E66 for ; Sun, 28 Feb 2021 21:32:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230490AbhB1Vbo (ORCPT ); Sun, 28 Feb 2021 16:31:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:24203 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231298AbhB1Vbl (ORCPT ); Sun, 28 Feb 2021 16:31:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614547814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CXqPeJKg2QGKVw3n7fJTnHQgpBneaYrsq3vZdSqlW7k=; b=U/jhKI033QpHHFgi0QSbjrxqCMaNZS6OhPfIIdQLnDz51DnzSrxdLPuqG3mOBDOD5QDv3q 1C/BrMbRZaTBrAHRgdpktqaun+i9UB0nfLkvpMEn3N/Xqr5tzFro4UjferR3nXzHNQDnS+ vI4aZDXjE/cxfCHhWH7tF/d0Kx9BIHI= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-3CGj4FqvN6qVObsfU8ilww-1; Sun, 28 Feb 2021 16:30:13 -0500 X-MC-Unique: 3CGj4FqvN6qVObsfU8ilww-1 Received: by mail-ed1-f70.google.com with SMTP id cq11so1625306edb.14 for ; Sun, 28 Feb 2021 13:30:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CXqPeJKg2QGKVw3n7fJTnHQgpBneaYrsq3vZdSqlW7k=; b=R1dZg4EZzYBJgYL95m7IBRKu3z0xVdflP6CezHrp9yQkp9NyIymZVCDv6w2vrDvmdh 6Xa2dlO2cfcfuaro8nyX6EnDLe19996DkPU2pBdCLNtGkUHIBAPmVloiNYsaPFjXgRYR n4NidnN2rAeJYdVRzn06ns0mo/OSdApSRZAGOX6qeadoMqI5mJOFKDX/YnM/SK+/Va/0 fdOrc248VgPIo5lREuOZ4oRrMhM62lFeJKb2us284xZRW6k/RkPhKuyduwjCfmOHaGzR a8CWnz4mJMuj9HQBA6kM8ogJrNGeUGeAlw3E8wr/dvBlbbrbVgaeW0U5YHOSyXmIV7MA fGRA== X-Gm-Message-State: AOAM532J1rlRH42TxFoBWP1IEWg/bo8ypcwasaplYd0QWSH7cpdnWonG VsbnDPY2kil6+QO6lmMoCs8EKQOWa1kGOWu1VtQzxofUMCCPYshI66ozoeMMG0mcBbx7NYPR6An poHyXfET/TT6I4LmN X-Received: by 2002:a05:6402:3047:: with SMTP id bu7mr13480400edb.227.1614547811754; Sun, 28 Feb 2021 13:30:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQe0ItppMYhgmAUA2vjPEcmW4kC/4bt6WO+XXuj+FLAiEv0vViE+9442NUKWzZGOmTe4jrsA== X-Received: by 2002:a05:6402:3047:: with SMTP id bu7mr13480386edb.227.1614547811608; Sun, 28 Feb 2021 13:30:11 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id e4sm11440644ejz.4.2021.02.28.13.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Feb 2021 13:30:11 -0800 (PST) Date: Sun, 28 Feb 2021 16:30:08 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Si-Wei Liu , elic@nvidia.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero Message-ID: <20210228162909-mutt-send-email-mst@kernel.org> References: <20210223082536-mutt-send-email-mst@kernel.org> <3ff5fd23-1db0-2f95-4cf9-711ef403fb62@oracle.com> <20210224000057-mutt-send-email-mst@kernel.org> <0559fd8c-ff44-cb7a-8a74-71976dd2ee33@redhat.com> <20210224014232-mutt-send-email-mst@kernel.org> <20210224021222-mutt-send-email-mst@kernel.org> <20210224034240-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Archived-At: List-Archive: List-Post: On Wed, Feb 24, 2021 at 05:30:37PM +0800, Jason Wang wrote: > > On 2021/2/24 4:43 下午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: > > > Basically on first guest access QEMU would tell kernel whether > > > guest is using the legacy or the modern interface. > > > E.g. virtio_pci_config_read/virtio_pci_config_write will call ioctl(ENABLE_LEGACY, 1) > > > while virtio_pci_common_read will call ioctl(ENABLE_LEGACY, 0) > > > > > > > > > But this trick work only for PCI I think? > > > > > > Thanks > > ccw has a revision it can check. mmio does not have transitional devices > > at all. > > > Ok, then we can do the workaround in the qemu, isn't it? > > Thanks which one do you mean? -- MST