From: Pavel Machek <pavel@ucw.cz>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, linux-leds@vger.kernel.org,
Dan Murphy <dmurphy@ti.com>, Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
"David S. Miller" <davem@davemloft.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Ben Whitten <ben.whitten@gmail.com>
Subject: Re: [PATCH RFC leds + net-next 3/7] leds: trigger: add API for HW offloading of triggers
Date: Mon, 1 Mar 2021 11:38:52 +0100 [thread overview]
Message-ID: <20210301103852.GB31897@duo.ucw.cz> (raw)
In-Reply-To: <20201030114435.20169-4-kabel@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
Hi!
> If the trigger with given configuration cannot be offloaded, the method
> should return -EOPNOTSUPP, in which case the trigger must blink the LED
> in SW.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> +
> +If the second argument (enable) to the trigger_offload() method is false, any
> +active HW offloading must be deactivated.
Are errors permitted in the "disable" case?
> +static inline void led_trigger_offload_stop(struct led_classdev *led_cdev)
> +{
> + if (!led_cdev->trigger_offload)
> + return;
> +
> + if (led_cdev->offloaded)
> + led_cdev->trigger_offload(led_cdev, false);
> +}
Set offloaded to false?
Let me check the rest to decide if this makes sense.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-03-01 10:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 11:44 [PATCH RFC leds + net-next 0/7] netdev trigger offloading and LEDs on Marvell PHYs Marek Behún
2020-10-30 11:44 ` [PATCH RFC leds + net-next 1/7] leds: trigger: netdev: don't explicitly zero kzalloced data Marek Behún
2020-11-25 12:34 ` Pavel Machek
2020-10-30 11:44 ` [PATCH RFC leds + net-next 2/7] leds: trigger: netdev: simplify the driver by using bit field members Marek Behún
2020-10-30 22:37 ` Jacek Anaszewski
2020-10-30 23:45 ` Marek Behún
2020-11-01 16:40 ` Jacek Anaszewski
2021-03-01 10:30 ` Pavel Machek
2020-10-30 11:44 ` [PATCH RFC leds + net-next 3/7] leds: trigger: add API for HW offloading of triggers Marek Behún
2021-03-01 10:38 ` Pavel Machek [this message]
2020-10-30 11:44 ` [PATCH RFC leds + net-next 4/7] leds: trigger: netdev: support HW offloading Marek Behún
2020-11-05 14:44 ` Marek Behún
2021-03-01 10:44 ` Pavel Machek
2020-10-30 11:44 ` [PATCH RFC leds + net-next 5/7] net: phy: add simple incrementing phyindex member to phy_device struct Marek Behún
2021-03-01 10:46 ` Pavel Machek
2020-10-30 11:44 ` [PATCH RFC leds + net-next 6/7] net: phy: add support for LEDs connected to ethernet PHYs Marek Behún
2021-03-01 10:52 ` Pavel Machek
2020-10-30 11:44 ` [PATCH RFC leds + net-next 7/7] net: phy: marvell: support LEDs connected on Marvell PHYs Marek Behún
2020-11-25 12:38 ` Pavel Machek
2021-03-01 11:05 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301103852.GB31897@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=ben.whitten@gmail.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kabel@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).