From: David Miller <davem@davemloft.net>
To: vladimir.oltean@nxp.com
Cc: jakub@cloudflare.com, alobakin@pm.me, kuba@kernel.org,
ast@kernel.org, andriin@fb.com, dcaratti@redhat.com,
gnault@redhat.com, wenxu@ucloud.cn, eranbe@nvidia.com,
mcroce@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID
Date: Sun, 14 Mar 2021 14:31:01 -0700 (PDT) [thread overview]
Message-ID: <20210314.143101.1456394019713348728.davem@davemloft.net> (raw)
In-Reply-To: <20210314204449.6ogfogeiqfwwqfso@skbuf>
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: Sun, 14 Mar 2021 20:44:49 +0000
> On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote:
>> On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote:
>>
>> Smells like a breaking change for existing consumers of this value.
>>
>> How about we change the type of flow_dissector_key_icmp{}.id to __be16
>> instead to make sparse happy?
>
> The struct flow_dissector_key_icmp::id only appears to be used in
> bond_xmit_hash, and there, the exact value doesn't seem to matter.
>
> This appears to be a real bug and not just to appease sparse:
> ih->un.echo.id has one endianness and "1" has another. Both cannot
> be correct.
Agreed, so I will apply this, thanks.
next prev parent reply other threads:[~2021-03-14 21:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 20:08 [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID Alexander Lobakin
2021-03-14 20:21 ` Jakub Sitnicki
2021-03-14 20:44 ` Vladimir Oltean
2021-03-14 21:31 ` David Miller [this message]
2021-03-14 22:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210314.143101.1456394019713348728.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alobakin@pm.me \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=dcaratti@redhat.com \
--cc=eranbe@nvidia.com \
--cc=gnault@redhat.com \
--cc=jakub@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).