From: Jiri Olsa <jolsa@kernel.org>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@chromium.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: [RFC PATCH bpf-next 0/4] bpf: Tracing programs re-attach
Date: Sun, 28 Mar 2021 13:26:25 +0200 [thread overview]
Message-ID: <20210328112629.339266-1-jolsa@kernel.org> (raw)
hi,
while adding test for pinning the module while there's
trampoline attach to it, I noticed that we don't allow
link detach and following re-attach for trampolines.
I'm not sure this was on purpose, but seems as natural
use of the interface, although the only user is the test
for now.
You need to have patch [1] from bpf tree for test module
attach test to pass.
thanks,
jirka
[1] https://lore.kernel.org/bpf/20210326105900.151466-1-jolsa@kernel.org/
---
Jiri Olsa (4):
bpf: Allow trampoline re-attach
selftests/bpf: Add re-attach test to fentry_test
selftests/bpf: Add re-attach test to fexit_test
selftests/bpf: Test that module can't be unloaded with attached trampoline
kernel/bpf/syscall.c | 25 +++++++++++++++++++------
kernel/bpf/trampoline.c | 2 +-
tools/testing/selftests/bpf/prog_tests/fentry_test.c | 58 +++++++++++++++++++++++++++++++++++++++++++++-------------
tools/testing/selftests/bpf/prog_tests/fexit_test.c | 58 +++++++++++++++++++++++++++++++++++++++++++++-------------
tools/testing/selftests/bpf/prog_tests/module_attach.c | 23 +++++++++++++++++++++++
5 files changed, 133 insertions(+), 33 deletions(-)
next reply other threads:[~2021-03-28 11:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 11:26 Jiri Olsa [this message]
2021-03-28 11:26 ` [RFC PATCH bpf-next 1/4] bpf: Allow trampoline re-attach Jiri Olsa
2021-03-30 1:18 ` Song Liu
2021-04-03 11:24 ` Toke Høiland-Jørgensen
2021-04-03 18:21 ` Alexei Starovoitov
2021-04-05 14:08 ` Jiri Olsa
2021-04-05 14:15 ` Toke Høiland-Jørgensen
2021-04-05 21:58 ` Jiri Olsa
2021-04-05 14:06 ` Jiri Olsa
2021-03-28 11:26 ` [RFC PATCH bpf-next 2/4] selftests/bpf: Add re-attach test to fentry_test Jiri Olsa
2021-03-30 1:23 ` Song Liu
2021-03-30 20:02 ` Jiri Olsa
2021-03-28 11:26 ` [RFC PATCH bpf-next 3/4] selftests/bpf: Add re-attach test to fexit_test Jiri Olsa
2021-03-28 11:26 ` [RFC PATCH bpf-next 4/4] selftests/bpf: Test that module can't be unloaded with attached trampoline Jiri Olsa
2021-03-30 6:12 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210328112629.339266-1-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).