From: David Miller <davem@davemloft.net>
To: lyl2019@mail.ustc.edu.cn
Cc: santosh.shilimkar@oracle.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/rds: Fix a use after free in rds_message_map_pages
Date: Tue, 30 Mar 2021 17:02:28 -0700 (PDT) [thread overview]
Message-ID: <20210330.170228.191449180243560631.davem@davemloft.net> (raw)
In-Reply-To: <20210330101602.22505-1-lyl2019@mail.ustc.edu.cn>
From: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Date: Tue, 30 Mar 2021 03:16:02 -0700
> @@ -348,7 +348,7 @@ struct rds_message *rds_message_map_pages(unsigned long *page_addrs, unsigned in
> rm->data.op_sg = rds_message_alloc_sgs(rm, num_sgs);
> if (IS_ERR(rm->data.op_sg)) {
> rds_message_put(rm);
> - return ERR_CAST(rm->data.op_sg);
> + return ERR_PTR(-ENOMEM);
> }
>
> for (i = 0; i < rm->data.op_nents; ++i) {
Maybe instead do:
int err = ERR_CAST(rm->data.op_sg);
rds_message_put(rm);
return err;
Then if rds_message_alloc_sgs() starts to return other errors, they will propagate.
Thank you.
next prev parent reply other threads:[~2021-03-31 0:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 10:16 [PATCH] net/rds: Fix a use after free in rds_message_map_pages Lv Yunlong
2021-03-31 0:02 ` David Miller [this message]
2021-03-31 2:02 ` lyl2019
-- strict thread matches above, loose matches on Subject: below --
2021-03-11 8:46 Lv Yunlong
2021-03-19 2:25 ` lyl2019
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330.170228.191449180243560631.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).