netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()
@ 2021-03-31  8:36 Yang Yingliang
  2021-03-31 22:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-03-31  8:36 UTC (permalink / raw)
  To: netdev, tipc-discussion; +Cc: davem

Add the missing destroy_workqueue() before return from
tipc_crypto_start() in the error handling case.

Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 net/tipc/crypto.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c
index 6f64acef73dc..76b8428c94a7 100644
--- a/net/tipc/crypto.c
+++ b/net/tipc/crypto.c
@@ -1492,6 +1492,8 @@ int tipc_crypto_start(struct tipc_crypto **crypto, struct net *net,
 	/* Allocate statistic structure */
 	c->stats = alloc_percpu_gfp(struct tipc_crypto_stats, GFP_ATOMIC);
 	if (!c->stats) {
+		if (c->wq)
+			destroy_workqueue(c->wq);
 		kfree_sensitive(c);
 		return -ENOMEM;
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()
  2021-03-31  8:36 [PATCH -next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start() Yang Yingliang
@ 2021-03-31 22:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-31 22:20 UTC (permalink / raw)
  To: Yang Yingliang; +Cc: netdev, tipc-discussion, davem

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 31 Mar 2021 16:36:02 +0800 you wrote:
> Add the missing destroy_workqueue() before return from
> tipc_crypto_start() in the error handling case.
> 
> Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> 
> [...]

Here is the summary with links:
  - [-next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()
    https://git.kernel.org/netdev/net-next/c/ac1db7acea67

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-31 22:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31  8:36 [PATCH -next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start() Yang Yingliang
2021-03-31 22:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).