From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390F9C433DB for ; Wed, 31 Mar 2021 12:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E204261998 for ; Wed, 31 Mar 2021 12:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235385AbhCaMCG (ORCPT ); Wed, 31 Mar 2021 08:02:06 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:51775 "EHLO mail-40134.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235026AbhCaMBf (ORCPT ); Wed, 31 Mar 2021 08:01:35 -0400 Date: Wed, 31 Mar 2021 12:01:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1617192093; bh=z8CUaRMV+W1DdXAmNRPxHigof0va9uxxc3ghbazANQw=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=lZ9Y2+Rx9IMXJGyzGR1r8fCec6Hg5fzSGRUVXr+KqhJO2JmCyO/h1DrmLR0u3kV8E 8NbVOmjwBLwIxjYnWpeoSXgfZ8meMiqtFXZmSq4Sp9WeHtTG7uknH02cIha4dUxCEO s5xMMYX9SFqoKZs/1n+t+DSs22IvE1dQrKRXpX45sUI7rLQ4To1kqPgaH0fcuKb77S Ir/QdFpJRPFPW6RYkq4Hs+yLKhiUEEFGMkttnRr3kCTUQ6Tsi7Dn6xOuA5v+PH09yU WFPNnfLn2C19CgASzQoNrNSLUdSq2k1vyduxgsvlM9mORR+llDW8xiTZpzlrXgABad Uhfl9AhYp5zUw== To: Magnus Karlsson From: Alexander Lobakin Cc: Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Xuan Zhuo , =?utf-8?Q?Bj=C3=B6rn_T=C3=B6pel?= , Magnus Karlsson , Jonathan Lemon , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Network Development , bpf , open list Reply-To: Alexander Lobakin Subject: Re: [PATCH bpf-next 0/2] xsk: introduce generic almost-zerocopy xmit Message-ID: <20210331120116.2671-1-alobakin@pm.me> In-Reply-To: References: <20210330231528.546284-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Magnus Karlsson Date: Wed, 31 Mar 2021 11:44:45 +0200 > On Wed, Mar 31, 2021 at 1:17 AM Alexander Lobakin wrote: > > > > This series is based on the exceptional generic zerocopy xmit logics > > initially introduced by Xuan Zhuo. It extends it the way that it > > could cover all the sane drivers, not only the ones that are capable > > of xmitting skbs with no linear space. > > > > The first patch is a random while-we-are-here improvement over > > full-copy path, and the second is the main course. See the individual > > commit messages for the details. > > > > The original (full-zerocopy) path is still here and still generally > > faster, but for now it seems like virtio_net will remain the only > > user of it, at least for a considerable period of time. > > > > Alexander Lobakin (2): > > xsk: speed-up generic full-copy xmit > > xsk: introduce generic almost-zerocopy xmit > > > > net/xdp/xsk.c | 33 +++++++++++++++++++++++---------- > > 1 file changed, 23 insertions(+), 10 deletions(-) > > > > -- > > Well, this is untested. I currently don't have an access to my setup > > and is bound by moving to another country, but as I don't know for > > sure at the moment when I'll get back to work on the kernel next time, > > I found it worthy to publish this now -- if any further changes will > > be required when I already will be out-of-sight, maybe someone could > > carry on to make a another revision and so on (I'm still here for any > > questions, comments, reviews and improvements till the end of this > > week). > > But this *should* work with all the sane drivers. If a particular > > one won't handle this, it's likely ill. > > Thanks Alexander. I will take your patches for a spin on a couple of > NICs and get back to you, though it will be next week due to holidays > where I am based. Thanks a lot! Any tests will be much appreciated. I'll publish v2 in a moment though, want to drop a couple of micro-optimizations. > > -- > > 2.31.1 Al